[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[bpel-dev] Bugzilla 391913 - Reintroduce expression editors

Hi all,

Lorenzo Bettini has kindly volunteered to take on the task of fixing the expression editors extension point in the BPEL Designer, which was removed for the Juno release (see [1]). I have merged his first set of changes from gerrit (changes/16/8216/3) into the "develop" branch. We'll merge this back into "master" once this work is complete and then do either a minor or major release, depending on whether the API will be backward compatible or not.

I'll continue to post updates to this mail list as changes are merged into the repository. Please let us know if anything breaks during this process.

Thanks!
Bob

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=391913


----- Original Message -----
> It took me a while to familiarize myself with the BPEL code again,
> but I think I've found the place in the code to add custom
> expression editor validation hooks.
> All of the validation code is in the o.e.b.validator plug-in; the two
> classes you're interested in are FromValidator and ToValidator. Have
> a look at the "expression variant" validation rule in the
> rule_CheckExpressionVariant_50() methods for both of these.
> 
> The plug-in that contributes a custom expression editor should
> (must?) also provide a validator factory with the
> org.eclipse.bpel.validator.factories extension point. You can use
> the implementation of XPath Validator in
> org.eclipse.bpel.validator.xpath.Factory as a starting point.
> 
> HTH
> Bob
> 
> ----- Original Message -----
> > I've pushed to gerrit (in the bug you see a description of what
> > I've
> > done up to now)...  the validation should be performed only if the
> > expression is an Xpath expression, but I still haven't understood
> > where
> > to fix this...
> > 
> > cheers
> > 	Lorenzo
> > 
> > On 10/15/2012 03:41 PM, Bob Brodt wrote:
> > > Excellent - thanks Lorenzo.
> > > Bob
> > > 
> > > ----- Original Message -----
> > >> I've also created a bug
> > >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=391913 to track
> > >> this
> > >>
> > >> I should be able to push something to gerrit soon :)
> > >>
> > >> cheers
> > >> 	Lorenzo
> > >>
> > >> On 10/11/2012 11:55 AM, Bob Brodt wrote:
> > >>> Hi Lorenzo,
> > >>>
> > >>> Thanks for helping out! Please keep us informed about your
> > >>> progress
> > >>> and please don't hesitate to ask if you need help :)
> > >>>
> > >>> Cheers!
> > >>> Bob
> > >>>
> > >>> ----- Original Message -----
> > >>>> On 06/04/2012 03:55 PM, Vincent Zurczak wrote:
> > >>>>> Hi,
> > >>>>>
> > >>>>> Le 04/06/2012 15:47, Lorenzo Bettini a Ãcrit :
> > >>>>>> Can we start trying to do something ourselves about that?
> > >>>>>>  We
> > >>>>>> can
> > >>>>>> start with the previous extension point mechanism, is it
> > >>>>>> still
> > >>>>>> there
> > >>>>>> somewhere?
> > >>>>>
> > >>>>> Sure. You can create a branch from the Git master branch.
> > >>>>> Make your modifications and propose them as a patch in the
> > >>>>> Bugzilla.
> > >>>>> Soon, there will be Gerrit for code reviews... that will be
> > >>>>> easier
> > >>>>> then.
> > >>>>>
> > >>>>> The original extension points are still available in the
> > >>>>> org.eclipse.bpel.ui and org.eclipse.bpel.common plug-ins (on
> > >>>>> the
> > >>>>> master
> > >>>>> branch).
> > >>>>
> > >>>> Hi
> > >>>>
> > >>>> I'd like to start working on bringing back the previous
> > >>>> extension
> > >>>> point
> > >>>> mechanism (according to what we discussed); has gerrit been
> > >>>> setup
> > >>>> for
> > >>>> bpel?
> > >>>>
> > >>>> cheers
> > >>>> 	Lorenzo
> > >>>>
> > >>>>
> > >>
> > >>
> > >> --
> > >> Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
> > >> ICQ# lbetto, 16080134     (GNU/Linux User # 158233)
> > >> HOME: http://www.lorenzobettini.it MUSIC:
> > >> http://www.purplesucker.com
> > >> http://www.myspace.com/supertrouperabba
> > >> BLOGS: http://tronprog.blogspot.com
> > >>  http://longlivemusic.blogspot.com
> > >> http://www.gnu.org/software/src-highlite
> > >> http://www.gnu.org/software/gengetopt
> > >> http://www.gnu.org/software/gengen
> > >> http://doublecpp.sourceforge.net
> > >> _______________________________________________
> > >> bpel-dev mailing list
> > >> bpel-dev@xxxxxxxxxxx
> > >> https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > >>
> > > _______________________________________________
> > > bpel-dev mailing list
> > > bpel-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > > 
> > 
> > 
> > --
> > Lorenzo Bettini, PhD in Computer Science, DI, Univ. Torino
> > ICQ# lbetto, 16080134     (GNU/Linux User # 158233)
> > HOME: http://www.lorenzobettini.it MUSIC:
> > http://www.purplesucker.com
> > http://www.myspace.com/supertrouperabba
> > BLOGS: http://tronprog.blogspot.com
> >  http://longlivemusic.blogspot.com
> > http://www.gnu.org/software/src-highlite
> > http://www.gnu.org/software/gengetopt
> > http://www.gnu.org/software/gengen http://doublecpp.sourceforge.net
> > _______________________________________________
> > bpel-dev mailing list
> > bpel-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/bpel-dev
> > 
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev
>