Re: [bpel-dev] Beautify XML for extension activities

[Bob Brodt <bbrodt@xxxxxxxxxx>]

OK, this is #1 in my work queue for today :)

_______________________________________
Robert ("Bob") Brodt
Senior Software Engineer, JBoss Riftsaw
JBoss by Red Hat

----- Original Message -----
> Hi Bob,
> 
> I wanted to revert the change to the model (that introduced an own
> element for the ExtensibilityElement), not the renaming of the
> implementation class ExtensibilityElementImpl to
> BPELExtensibilityElementImpl. From my point of view it's bad practice
> to use the same name for a superclass and a subclass. It's up to you
> to apply that change.
> 
> Tobias
> 
> ________________________________
> 
> Von: bpel-dev-bounces@xxxxxxxxxxx im Auftrag von Bob Brodt
> Gesendet: Do 24.3.11 18:19
> An: BPEL Designer project developer discussions.
> Cc: zacharias@xxxxxxxxxx
> Betreff: Re: [bpel-dev] Beautify XML for extension activities
> 
> 
> Hi Tobias,
> 
> Last night I started looking at the patch you submitted for 340654 but
> it looks like the changes for BPELExtensibilityElement are still in
> there. From your last comment in bugzilla it sounded like you wanted
> to revert that change that was added by a previous patch. Can you
> please resbumit a new patch with your current fixes?
> 
> Thanks!
> 
> _______________________________________
> Robert ("Bob") Brodt
> Senior Software Engineer, JBoss Riftsaw
> JBoss by Red Hat
> 
> 
> ________________________________
> 
> 
> Hi Bob,
> 
> I created two CRs for that, one for the model synchronization (#340654
> <https://bugs.eclipse.org/bugs/show_bug.cgi?id=340654> ) and one for
> the new extension activitiy structure (#340662
> <https://bugs.eclipse.org/bugs/show_bug.cgi?id=340662> ). I changed
> the latter a little bit from my first idea, so any further suggestions
> are appreciated.
> 
> I hope you integrate the first CR as soon as possible, as it blocks a
> prepared patch for the second one.
> 
> Thanks, Tobias
> 
> ________________________________
> 
> Von: bpel-dev-bounces@xxxxxxxxxxx im Auftrag von Bob Brodt
> Gesendet: Fr 18.3.11 17:38
> An: BPEL Designer project developer discussions.
> Betreff: Re: [bpel-dev] Beautify XML for extension activities
> 
> 
> 
> Hi Tobias,
> 
> I ran across the same kinds of issues you are talking about when I was
> working my way through the updated extension activity sample plugin,
> but I ran out of time to investigate this further. If you have a patch
> that will fix some of these issues, please go ahead and add it to
> bugzilla and let me know so I can review/apply it. I'll probably have
> to revisit the extension activity sample again and fix it :(
> 
> BTW, please be sure to update the ecore and regenerate the model for
> the affected classes. You'll probably have to start there anyway to
> add the ExtensionActivityBase object...but be careful - I think the
> ecore and implementation files are already out of sync (i.e. SOMEbody
> bypassed the ecore model and made changes directly to some of the java
> impl files.) I have no idea how or when this happened, but I didn't do
> it ;) Resynchronizing these is also on my [already too long] list of
> things to do.
> 
> Thanks for your help!
> 
> _______________________________________
> Robert ("Bob") Brodt
> Senior Software Engineer, JBoss Riftsaw
> JBoss by Red Hat
> 
> ----- Original Message -----
> > Hi Bob,
> >
> > as we now continue working on the SMILA extensions for the BPEL
> > designer (as the next step of our simplification process), I would
> > like to return to my last proposal of introducing an own EMF object
> > for the ExtensionActivity XML element:
> >
> > Current implementation of mapping between XML nodes and EMF objects:
> > <sequence name="..."> - SequenceImpl
> > <extensionActivity> - MyActivityImpl (extends ExtensionActivityImpl)
> > <myActivity> - Must be handled by MyActivityImpl, but is not
> > directly
> > connected
> > ...
> > </myActivity>
> > </extensionActivity>
> > </sequence>
> >
> > My proposal is to introduce a new (abstract) base class
> > "ExensionActivityBaseImpl" for the direct connection of the XML
> > elements:
> > <sequence name="..."> - SequenceImpl
> > <extensionActivity> - ExtensionActivityImpl
> > <myActivity> - MyActivityImpl (extends ExensionActivityBaseImpl)
> > ...
> > </myActivity>
> > </extensionActivity>
> > </sequence>
> >
> > This would ease the synchronization between the XML elements and the
> > EMF objects.
> >
> > Additionally we would avoid the following problem: Suppose someone
> > is
> > using the source tab to delete everything inside
> > <extensionsActivity>
> > and add some different activity in there. As the connected XML
> > element
> > remains, so is the MyActivityImpl child in the SequenceImpl.
> >
> > Should I create a patch and CR for my proposal?
> >
> > Tobias
> >
> > Btw. Even your code in ExtensionSampleActivityDeserializer shows the
> > problems with the current implementation: The lines with
> > "sa.setElement(saElement);" have no effect, as the parent element is
> > set in the calling method.
> >
> 
> 
> 
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev
> 
> 
> 
> 
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev