| Re: [bpel-dev] Beautify XML for extension activities |
Hi Tobias,
I ran across the same kinds of issues you are talking about when I was working my way through the updated extension activity sample plugin, but I ran out of time to investigate this further. If you have a patch that will fix some of these issues, please go ahead and add it to bugzilla and let me know so I can review/apply it. I'll probably have to revisit the extension activity sample again and fix it :(
BTW, please be sure to update the ecore and regenerate the model for the affected classes. You'll probably have to start there anyway to add the ExtensionActivityBase object...but be careful - I think the ecore and implementation files are already out of sync (i.e. SOMEbody bypassed the ecore model and made changes directly to some of the java impl files.) I have no idea how or when this happened, but I didn't do it ;) Resynchronizing these is also on my [already too long] list of things to do.
Thanks for your help!
_______________________________________
Robert ("Bob") Brodt
Senior Software Engineer, JBoss Riftsaw
JBoss by Red Hat
----- Original Message -----
> Hi Bob,
>
> as we now continue working on the SMILA extensions for the BPEL
> designer (as the next step of our simplification process), I would
> like to return to my last proposal of introducing an own EMF object
> for the ExtensionActivity XML element:
>
> Current implementation of mapping between XML nodes and EMF objects:
> <sequence name="..."> - SequenceImpl
> <extensionActivity> - MyActivityImpl (extends ExtensionActivityImpl)
> <myActivity> - Must be handled by MyActivityImpl, but is not directly
> connected
> ...
> </myActivity>
> </extensionActivity>
> </sequence>
>
> My proposal is to introduce a new (abstract) base class
> "ExensionActivityBaseImpl" for the direct connection of the XML
> elements:
> <sequence name="..."> - SequenceImpl
> <extensionActivity> - ExtensionActivityImpl
> <myActivity> - MyActivityImpl (extends ExensionActivityBaseImpl)
> ...
> </myActivity>
> </extensionActivity>
> </sequence>
>
> This would ease the synchronization between the XML elements and the
> EMF objects.
>
> Additionally we would avoid the following problem: Suppose someone is
> using the source tab to delete everything inside <extensionsActivity>
> and add some different activity in there. As the connected XML element
> remains, so is the MyActivityImpl child in the SequenceImpl.
>
> Should I create a patch and CR for my proposal?
>
> Tobias
>
> Btw. Even your code in ExtensionSampleActivityDeserializer shows the
> problems with the current implementation: The lines with
> "sa.setElement(saElement);" have no effect, as the parent element is
> set in the calling method.
>