Re: [bpel-dev] Undo stacks patch

["Dennis Ushakov" <dennis.ushakov@xxxxxxxxx>]

Seems like it's ooops for me too.
I've forgot to update one method in new CompoundCommand(getModelRoots)
and it's crashing on validate edit, for example when selecting
something in quick pick.
It's fixed, Oleg, could you please commit it too.

Thanks,
Dennis

2008/6/25 Danilov, Oleg V <oleg.v.danilov@xxxxxxxxx>:
> Oooops, there is one more thing that I've forgot to mention.
>
> I've also added ability to initialize a variable used in a query action.
>
> There is a common problem - user attempting to copy something to a
> variable before it is initialized. If the target of the copy operation
> in the Assign activity is defined as a complex type, then user should
> add another copy operation to create the structure of the complex type
> before (s)he attempt to copy something to it. This is very difficult for
> users.
>
> Now bpel editor checks whether variable was not initialized before. If
> so then confirmation dialog appears. If user chooses Ok, then
> initialization template will be generated.
>
> Thanks,
>  Oleg
>
> Ps. Actually this feature is not well-tested so your comments and ideas
> will be very useful.
>
> -----Original Message-----
> From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Danilov, Oleg V
> Sent: Wednesday, June 25, 2008 4:21 PM
> To: BPEL Designer project developer discussions.
> Subject: RE: [bpel-dev] Undo stacks patch
>
> Hi all,
>
> Reviewed, committed.
>
> Btw, I've also updated Property tab of the Assign activity:
> - copy list is now more informative
> - fixed bug with not updating source tab in Expression editor
> - added "move up" and "move down" buttons
>
> Suggestions and comments are welcome :-)
>
> Thanks,
>  Oleg
>
> -----Original Message-----
> From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Dennis Ushakov
> Sent: Tuesday, June 24, 2008 1:06 PM
> To: BPEL Designer project developer discussions.
> Subject: [bpel-dev] Undo stacks patch
>
> Hi,
>
> Since the time we have source editor in BPEL editor the following
> problem has arised: two editors having two different command stacks,
> which are somewhat independent. (Actually text editor stack was always
> filled with "Undo text change" that was the result of updating DOM
> from EMF). I've rewritten the way that undo actions are handled. The
> primary editor for undo is now text editor and all the changes are
> recorded using dom recording mechanism and they're undone using text
> editor undo stack.
>
> The following issues had been resolved:
> - undoing change made in design view from the source tab resulted in
> inability to undo anything due to the way how the changes from EMF
> were propagated to DOM
> - undo/redo shortcuts (Ctrl-Z, Ctrl-Y) were not working and there was
> no undo/redo in the 'Edit' menu
> - editor was not marked dirty when all contents is removed from source
> tab
> - editor sometimes was opened in dirty state
> - editor got dirty after pasting xml data on an activity in design
> view, yet file was unchanged
>
> There are still two issues left:
> - the selection is not restored after undoing delete. I consider this
> a minor issue and continue working on it
> - editor is not marked clean after all changes are undone. This is an
> known issue in StructuredTextEditor (Eclipse bugzilla entries: 213109,
> 138100, 191754) and I've asked about it on the WTP dev list
>
> Also, from now instead of using
> org.eclipse.gef.commands.CompoundCommand one should prefer using
> org.eclipse.bpel.ui.commands.CompoundCommand.
> org.eclipse.bpel.ui.commands.CompoundCommand has the same
> functionality as the gef one, but it handles changes in all contained
> commands as a single change, not breaking into several commands. This
> allows to undo compound command (for example, insertion of a new
> activity) in a single undo action, not undoing them one by one (like
> undoing set activity name and then insertion of a new activity)
>
> Oleg, could you please verify and commit these changes?
>
> And if Oleg accepts these changes I'm asking everyone to take a look
> and to report any bugs with undo mechanism to me in case you find any.
> I'll fix them ASAP.
>
> Thanks,
> Dennis
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev
>
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev
>
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> bpel-dev mailing list
> bpel-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/bpel-dev
>