[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
RE: [bpel-dev] FromParts and ToParts commited
|
Hi Oleg,
yes, when regenerating the model all
of your changes were overwritten. And it seems as if I didn't restore all
of them. Sorry for that!
I'll take a look at these 5 methods
and check them in as soon as possible.
By the way, reconciliation stuff is
also missing in setVariable of OnEventImpl and OnMessageImpl. But I guess
these are on your TODO list...
Thanks
Michael
| Software Developer
- BPEL Editor / WID
|
| WSS Business Process Solutions
Development 1
|
| Dept. 4722, Bldg. 71032-01,
Room 086
|
| IBM Böblingen Laboratory
|
| Schönaicherstr. 220, D-71032
Böblingen |
|
| Notes:
| Michael Illiger2/Germany/IBM
|
Internet:
| milliger@xxxxxxxxxx
|
| Phone:
| ++49-(0)7031-16-1273
|
| Fax:
| ++49-(0)7031-16-4890 |
|
| IBM Deutschland Entwicklung
GmbH
|
| Chairman of the Supervisory
Board: Martin Jetter
|
| Board of Management: Herbert
Kircher (Chairman)
|
| Corporate Seat: Böblingen
|
| Commercial Register: Amtsgericht
Stuttgart, HRB 243294 |
|
"Danilov, Oleg V"
<oleg.v.danilov@xxxxxxxxx>
Sent by: bpel-dev-bounces@xxxxxxxxxxx
11/22/2007 04:10 PM
|
Please respond to
"BPEL Designer project developer discussions." <bpel-dev@xxxxxxxxxxx> |
|
|
To
| "BPEL Designer project developer
discussions." <bpel-dev@xxxxxxxxxxx>
|
|
cc
|
|
|
Subject
| RE: [bpel-dev] FromParts and ToParts
commited |
|
Hi Michael,
I just reviewed your changes related to the
reconciliation stuff. Great!
The only question is about missed checks
for isReconciling in these methods:
- InvokeImpl.setInputVariable
- InvokeImpl.setOutputVariable
- ReplyImpl.setFaultName
- ReplyImpl.setVariable
- ReceiveImpl.setCreateInstance
Did you remove these checks manually for
some reason? I guess all these methods were overwritten because you have
changed the model… We already discussed this problem with Simon – these
methods have tag @generated and changes could be lost in case if model
is generated again. It is our stupid blunder, sorry for that. In the near
future we will review all sources and remove this tag. What we need is
just a time. Unfortunately day consists of 24 hours. Personally, I would
prefer 48 hours per day J
Thanks,
Oleg
From: bpel-dev-bounces@xxxxxxxxxxx
[mailto:bpel-dev-bounces@xxxxxxxxxxx] On Behalf Of Michael Illiger2
Sent: Tuesday, November 20, 2007 5:14 PM
To: bpel-dev@xxxxxxxxxxx
Subject: [bpel-dev] FromParts and ToParts commited
Hi,
We just commited some code for BPEL 2.0 part-mapping stuff for our PartnerActivities.
I had to change our model classes for FromPart, ToPart, FromParts, ToParts
and all PartnerActivities. I also tried to implement the EMF-DOM reconciliation
stuff. for these classes.
> Oleg: could you please review the changes I did in our model plugin
and tell me if I missed anything?
In the property pages I tried to reuse the "combo-box widgets"
Michal introduce for Partner, Operation and Variable in InvokeImplSection.
This works quite well with some minor issues. E.g. there are not always
all variables with matching types listed in the proposal box. And the "fault-name"
combo box doesn't provide any proposals.
> Michal: if you find some time could you please take a look at #updatePartMappingWidgets
in InvokeVariablesSection and review if I used your widgets as they are
intended to use? And could you also please take a look at the faultname
stuff for Reply. If I look at the CVS history I wonder if this has ever
worked...
Oh, and not to forget: We also commited Oleg's latest source-tab patch
(sourcetab-20071116.patch)
Cheers Michael
--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: 125252, Moscow, Russian Federation,
Chapayevsky Per, 14.
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
bpel-dev mailing list
bpel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/bpel-dev
