RE: [bpel-dev] patch6=add-rename-design-element-affect-source-tab

["Tishkov, Vitaly V" <vitaly.v.tishkov@xxxxxxxxx>]

Hi Simon,

>I reviewed the code and I am happy with it - only I haven't fully
>understood the purpose of the myBPELWriter inner class that you define in
>the commands that you changed - maybe you can explain a word w.r.t. that ?!

I need to access 
org.eclipse.bpel.model.resource.BPELWriter.activity2XML() 
which is protected and thus inaccessible from org.eclipse.bpel.ui.commands.InsertInContainerCommand

So, I extended BPELWriter and made activity2XML() public. This trick is often used in the project (e.g. see BPELEditor.setGraphicalViewer()).

Does it explains the need of MyBPELWriter?

Thanks,
	Vitaly.

>-----Original Message-----
>From: bpel-dev-bounces@xxxxxxxxxxx [mailto:bpel-dev-bounces@xxxxxxxxxxx] On
>Behalf Of Simon D Moser
>Sent: Sunday, July 22, 2007 8:34 PM
>To: BPEL Designer project developer discussions.
>Cc: BPEL Designer project developer discussions.; bpel-dev-bounces@xxxxxxxxxxx
>Subject: Re: [bpel-dev] patch6=add-rename-design-element-affect-source-tab
>
>Hi Vitaly,
>
>first: I am deeply impressed!! This is great work so far!
>I tried the patch on a sanity check, and it seems to work  - although I
>found some more bugs - e.g.: don't try to undo deleted things etc, but that
>is just normal at that stage of the game - actually, I expected to see
>things more fragile then they actually are !!
>
>I reviewed the code and I am happy with it - only I haven't fully
>understood the purpose of the myBPELWriter inner class that you define in
>the commands that you changed - maybe you can explain a word w.r.t. that ?!
>Either way, I have committed the code - so you can get it from the known
>branch ;-)
>
>Cheers
>Simon
>
>
>Simon Moser, M.Eng.
>
>
>
> Websphere Integration       Mail:           IBM Deutschland Entwicklung
> Developer Development       smoser@xxxxxx.  GmbH
> Team Lead BPEL Editor       com             Vorsitzender des
> Dept. 4722, Bldg.           Phone:          Aufsichtsrats: Martin Jetter
> 71032-01, Room 086          +49-7031-16-43  Geschäftsführung: Herbert
> Websphere Solutions and     04              Kircher
> Services                    Fax:            Sitz der Gesellschaft:
> IBM Deutschland             +49-7031-16-48  Böblingen
> Entwicklung GmbH            90              Registergericht: Amtsgericht
> Schönaicherstr. 220, D -                    Stuttgart, HRB 243294
> 71032 Boeblingen
>
>
>
>
>
>
>
>
>
>
>             "Tishkov, Vitaly
>             V"
>             <vitaly.v.tishkov                                          To
>             @intel.com>               "BPEL Designer project developer
>             Sent by:                  discussions."
>             bpel-dev-bounces@         <bpel-dev@xxxxxxxxxxx>
>             eclipse.org                                                cc
>
>                                                                   Subject
>             07/20/2007 07:15          [bpel-dev]
>             PM                        patch6=add-rename-design-element-af
>                                       fect-source-tab
>
>             Please respond to
>              "BPEL Designer
>             project developer
>               discussions."
>             <bpel-dev@eclipse
>                   .org>
>
>
>
>
>
>
>Hi Simon,
>
>Please find attached the 6th patch for the MultiTab-DomFacade branch.
>
>The first step towards real EMF and DOM models synchronization is done:
>- renaming existent elements and adding new ones in the design tab now
>reflect on the DOM model and the source tab contents.
>
>Classes added.
>   1. org.eclipse.bpel.ui.BPELModelAdapter.
>   2. org.eclipse.bpel.ui.BPELModelReconcileAdapter.
>   3. org.eclipse.bpel.ui.util.BPELEditorUtil.
>   4. org.eclipse.bpel.ui.util.BPELNodeAssociationManager.
>All these classes were created from the corresponding wsdl project classes.
>There is quite a lot of garbage in the code. I decided not to clean it up
>until the next patch.
>
>New dependencies.
>   1. org.eclipse.bpel.model now depends on org.eclipse.wst.xml.core and
>      org.elipse.wst.sse.core.
>   2. org.eclipse.bpel.ui now depends on org.eclipse.wst.xsd.ui and
>      org.eclipse.wst.wsdl.ui
>
>
>Known bugs and limitations.
>   1. Do not edit source in the source tab and then save the file. Changes
>      in the DOM model don't affect EMF model.
>   2. Elements are added into the DOM model (and thus in the source tab)
>      without the name attribute.
>   3. Renaming just added elements in the design tab doesn't affect the
>      corresponding nodes in the source tab until the file is saved.
>   4. The source tab content is not formatted after adding new elements in
>      the design tab.
>
>Thanks,
>            Vitaly.(See attached file:
>patch6=add-rename-design-element-affect-source-tab.txt)
>_______________________________________________
>bpel-dev mailing list
>bpel-dev@xxxxxxxxxxx
>https://dev.eclipse.org/mailman/listinfo/bpel-dev