Re: [birt-dev] Rules for PRs

[Wim Jongman <wim.jongman@xxxxxxxxx>]

Yes, I think that a review is required for any substantial commit. I think a committer has to request a review. Can this be done in GH?

Signed commits are not needed IMO because of the checks the foundation already requires.

Cheers,

Wim

On Sun, Mar 7, 2021 at 9:52 AM Alexander Lehmann <a.lehm@xxxxxx> wrote:

Hi all,

should we agree on some rules for PRs? Alexander F. mentioned for example an upper bound on the LoC per PR. I would like to suggest that a review must be made before a PR can be merged. Should we also require commits to be signed? This can both be accomplished throught a GitHub branch protection rule [1].

[1] https://docs.github.com/en/github/administering-a-repository/managing-a-branch-protection-rule

Best regards

Alex

_______________________________________________
birt-dev mailing list
birt-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/birt-dev