[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev] CheckIN:Fix bugzilla bug 184328 Filter on a computed column based on a date value does not work

- Summary:
CheckIN:Fix bugzilla bug 184328 Filter on a computed column based on a date value does not work


- Bugzilla Bug (s) Resolved:

[184328] Filter on a computed column based on a date value does not work

 

- Description:
When the column binding is referenced in _javascript_ _expression_, we do not convert its value to _javascript_ value. This lead to two problems:

1. Because the data set row values are converted to _javascript_ value during evaluation, this leads to the inconsistency of behavior.

2. For all column binding values referenced in _javascript_ _expression_, some native _javascript_ object functions(say, those for NativeDate) would not be usable.

 

Fix the bug by convert column binding values to _javascript_ data type value once they are used as _javascript_ object. Meanwhile keep the column binding value that returned through DtE API call as java data type. The unit test is added.

 

- Tests Description:
Unit Test.  


- Files Edited:

"/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/script/JSResultSetRow.java"

"/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/impl/BindingColumnsEvalUtil.java"

"/org.eclipse.birt.data/src/org/eclipse/birt/data/engine/_expression_/ExprEvaluateUtil.java"

 

"/org.eclipse.birt.data.tests/test/org/eclipse/birt/data/engine/binding/golden/FeaturesTest.test16.txt"

"/org.eclipse.birt.data.tests/test/org/eclipse/birt/data/engine/binding/FeaturesTest.java"

 


- Files Added:

 

 

 


- Files Deleted:

N/A

 

- Notes to Build Team:
N/A


- Notes to Developers:
N/A


- Notes to QA: 
 

N/A

 

- Notes to Documentation:  
N/A