[birt-dev] Checkin: Re-architectured chart interactivity code and fixed

["David Michonneau" <dmichonneau@xxxxxxxxxxx>]

- Summary:

Re-architectured chart interactivity code and fixed several related bugs:

 

- Bugzilla Bug (s) Resolved:

Interactivity missing color by category support in Swing/SWT                                            140629

SVG-Highlight, meter chart, color by category, add highlight to series, can not take effect    154013

Swing: Interactivity-ToggleVisibility work incorrectly.                                                        154179

Swing: Interactivity-Highlight work incorrectly for pie chart                                                154183

SWT: 3D Line Chart Interactivity-Highlight does not work for Value Series                          160610

Interactivity-Highlight does not work for 3D Line Chart                                                      160611

SWT: Meter Chart Interactivity-Highlight does not work correctly for Legend                       160612

SWT: Interactivity-ToggleVisibility work incorrectly.                                                          160627

 

- Description:

There are three interactivity renderers: Swing, SWT and SVG. The SVG one works fine in most cases, but SWT and Swing suffered from a design flaw in the original code, limiting them to “color by series” scenarios.

 

The interactivity code for SWT and Swing has been re-architectured to enable full interactivity support in all cases, particularly in the “color by categories” case.

 

The interactivity interface IUpdateNotifier is also simplified, some unnecessary methods that were added in 2.2 have been removed and are now handled automatically by the engine.

- Tests Description :
Visual tests

- Notes to Build Team:

- Notes to Developers:

- Notes to QA:

- Notes to Documentation:

- Files Edited:

 

"src/org/eclipse/birt/chart/device/swing/SwingRendererImpl.java" "src/org/eclipse/birt/chart/device/swing/SwingEventHandler.java"

"src/org/eclipse/birt/chart/render/Line.java" "src/org/eclipse/birt/chart/render/DialRenderer.java"

"src/org/eclipse/birt/chart/examples/api/script/ScriptCharts.java" "src/org/eclipse/birt/chart/examples/api/interactivity/SwingInteractivityViewer.java" "src/org/eclipse/birt/chart/examples/api/viewer/SwingChartViewerSelector.java" "src/org/eclipse/birt/chart/examples/api/script/java/DataPointsScript.java" "src/org/eclipse/birt/chart/examples/api/interactivity/SwtInteractivityViewer.java" "META-INF/MANIFEST.MF" "src/org/eclipse/birt/chart/examples/api/format/FormatChartsViewer.java" "src/org/eclipse/birt/chart/examples/api/data/DataChartsViewer.java" "src/org/eclipse/birt/chart/examples/api/interactivity/SvgInteractivityViewer.java" "src/org/eclipse/birt/chart/examples/api/interactivity/InteractivityCharts.java"

"src/org/eclipse/birt/chart/device/svg/SVGRendererImpl.java"

"src/org/eclipse/birt/chart/device/swt/ChartDeviceSwtActivator.java" "src/org/eclipse/birt/chart/device/swt/SwtRendererImpl.java" "src/org/eclipse/birt/chart/device/swt/SwtEventHandler.java"

"/org.eclipse.birt.chart.device.swt/src/org/eclipse/birt/chart/device/swt/SwtRendererImpl.java" "/org.eclipse.birt.chart.device.swt/src/org/eclipse/birt/chart/device/swt/ChartDeviceSwtActivator.java" "/org.eclipse.birt.chart.device.swt/src/org/eclipse/birt/chart/device/swt/SwtEventHandler.java"

"/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/viewer/SwingChartViewerSelector.java" "/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/format/FormatChartsViewer.java" "/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/data/DataChartsViewer.java" "/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/interactivity/SvgInteractivityViewer.java" "/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/interactivity/SwingInteractivityViewer.java" "/org.eclipse.birt.chart.examples/src/org/eclipse/birt/chart/examples/api/interactivity/SwtInteractivityViewer.java"

"/org.eclipse.birt.chart.device.svg/src/org/eclipse/birt/chart/device/svg/SVGRendererImpl.java"

"/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/RectangleRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/render/InteractiveRenderer.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/device/EmptyUpdateNotifier.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/render/AxesRenderer.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/ArcRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/PrimitiveRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/AreaRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/render/BaseRenderer.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/Polygon3DRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/OvalRenderEvent.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/device/IUpdateNotifier.java" "/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/event/PolygonRenderEvent.java"

"/org.eclipse.birt.chart.ui.extension/src/org/eclipse/birt/chart/ui/swt/wizard/internal/ChartPreviewPainter.java"

"/org.eclipse.birt.chart.device.extension/src/org/eclipse/birt/chart/device/swing/SwingRendererImpl.java" "/org.eclipse.birt.chart.device.extension/src/org/eclipse/birt/chart/device/swing/SwingEventHandler.java"

"/org.eclipse.birt.chart.engine.extension/src/org/eclipse/birt/chart/render/Line.java" "/org.eclipse.birt.chart.engine.extension/src/org/eclipse/birt/chart/render/DialRenderer.java"

- Files Added:

"/org.eclipse.birt.chart.engine/src/org/eclipse/birt/chart/render/InteractiveRenderer.java"

- Files Deleted