Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev] Checkin: fix head version bugs ODADesignFactory.getFactory() may return null in some cases.

- Summary:

oda.ODADesignFactory.java and oda.ODAFactory.java have only static methods. So, the call to oda.ODADesignFactory will not invoke start(BundleContext) of the plugin activator. However, if the user make calls to ModelOdaAdapter first, start(BundleContext) of the plugin activator will be invoked.

To solve this problem, used BIRT core factory service to create ODADesignFactory and ODAFactory instances.



- Bugzilla Bug (s) Resolved:

1. changed codes in oda.ODADesignFactory and oda.ODAFactory to use AdapterFactory to create instances.

2. moved plugin.ODADesignFactory.java and plugin.ODAFactory to the impl sub-package.



- Description:

Changed the way to create ODADesignFactory and ODAFactory.

- Tests Description :

JUnit test

- Files Edited:

/org.eclipse.birt.report.model.adapter.oda/BuildModelOdaAdapter.xml
/org.eclipse.birt.report.model.adapter.oda/customBuildCallbacks.xml
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/ModelOdaAdapter.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/ODADesignFactory.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/ODAFactory.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/ReportParameterAdapter.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/impl/AdapterFactory.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/plugin/ModelAdapterOdaPlugin.java



- Files Added:

/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/impl/ODADesignFactory.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/impl/ODAFactory.java



- Files Deleted:

/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/plugin/ODADesignFactory.java
/org.eclipse.birt.report.model.adapter.oda/src/org/eclipse/birt/report/model/adapter/oda/plugin/ODAFactory.java



- Notes to Build Team:



- Notes to Developers:



- Notes to QA:



- Notes to Documentation:

 

Rick Lu

Actuate Software Shanghai Center
Tel: (86)21-58826388
Fax: (86)21-58826002
Email: rlu@xxxxxxxxxxx
 


Back to the top