How about set the property
“units” to be invisible? So that user could not set units from BIRT Designer, but
API user could still use this property.
I agree with Wenfeng that we
either keep the property for both session and module, or remove from both.
I think for Model, BIRT designer
and API user are both our user. If we remove these two properties, it seems not
convenient for API user, because they must set units for each dimension property
of a report item instance like what our BIRT Designer does. Maybe they just want
to set unit once for each module, even session, and then every dimension property
could get the default units if they are not defined in ROM. As for special case, like font size, their default units have already
defined in ROM. (“mm” could be apply to font size, just not appropriate.)
Also, if we just make these
two properties invisible, it will save us a lot of work and the side effects is
least. Removing these two properties need do backward compatibility.
How do you think?
Best regards,
Jiaying Liu
Actuate Corporation - Shanghai R&D Center
( : (86)21-58826388
-----Original
Message-----
From: Yu Li
Sent: Wednesday,
March 28, 2007 2:45
PM
To: Wenfeng Li; Jiaying Liu;
'birt-dev@xxxxxxxxxxx'
Subject: RE: [birt-dev] API change
request
I think that is no problem for “mm” use for font size. All the
dimension property type can share the same unit list.
The original thinking to remove the default unit from Module was:
UI will always give a default unit for a dimension property value. And which
unit will be used as the default unit is defined by UI, this was discussed long
time ago. But from designer, the module default unit is editable. So when user
set the default unit for a module, he feels that value will never take effect.
There are default unit on both of the session and module. After looking at the
code, we think only leave the default unit on session is enough in case of the
code user has a convenient way to set a default unit for all dimension
properties, which do not have default value define in ROM.
Thanks!
Ivy
Actuate Software ShangHai center.
Tel: (86)21-58826388
Fax:(86)21-58826002
Email: yli@xxxxxxxxxxx
-----Original
Message-----
From: Wenfeng Li
Sent: 2007年3月28日
14:14
To: Yu Li; Jiaying Liu;
birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change
request
Does the default unit on the session object has
the same problem as the one on module that it is not meaningful for all
measures, for example, "mm" will not be meaningful for font
size. If we think this is not an issue, then module should be able to
have a default unit too, so that not all elements in the report have
to set the unit explicitly.
suggest
to either keep the property for both session and module, or remove from both.
From:
Yu Li
Sent: Tue 3/27/2007 11:02
PM
To: Wenfeng Li; Jiaying Liu;
birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change
request
If user call API directly but not from designer, they can create a
session, and they might want a default unit on a session. It is more convenient
for API caller. Bur from designer, it seems not very useful, and designer will
not provide a way for user to set the default unit from BIRT anyways. So,
should we keep the default unit on session and just remove the one from Module?
Thanks!
Ivy
Actuate Software ShangHai center.
Tel: (86)21-58826388
Fax:(86)21-58826002
Email: yli@xxxxxxxxxxx
-----Original
Message-----
From: birt-dev-bounces@xxxxxxxxxxx
[mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf
Of Wenfeng Li
Sent: 2007年3月27日
16:38
To: Jiaying Liu;
birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change
request
+1 for removing the report/module level unit
setting in BIRT report designer UI.
If
we are going to remove the default unit from module handle in model, shall we
also remove it from the session handle? Since both unit properties
will not apply to all element sizes, such as width and font can not share the
same unit.
From:
Jiaying Liu
Sent: Tue 3/27/2007 12:56
AM
To: Wenfeng Li;
birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change
request
Yes, BIRT report designer explicitly set the units whenever it set
the value for a report element’s dimension property.
If others develop a custom report designer that does not set the
unit, the default unit of this element defined in ROM will take effect. If it
is not defined in ROM, then the one setting on session handle will take effect.
Otherwise, a semantic warning will be thrown. (A dimension value without unit
may cause failure when engine render the report in html and pdf)
If we remove this property from module, then user can not set
general units for a single module any more, he/she could just set the units on
session, or on individual design element.
Even now, the general unit is not always suitable for all kinds of
elements, for example, if user set unit to be “mm”, but “mm” is not a common
unit for font size. So ROM defines some default units for those that suppose to
have their own default value. The default unit search route is:
ROM
Module
Session
The bug reporter thinks there should be a switch to decide either to use the metric system or the US/English system. But the unit he/she setting on module does not take effect since BIRT report designer has explicitly set units for elements. To avoid confusion, Qiangsheng suggests deprecating this property.
Best regards,
Jiaying Liu
Actuate Corporation - Shanghai R&D Center
( : (86)21-58826388
-----Original
Message-----
From: Wenfeng Li
Sent: Tuesday,
March 27, 2007 2:36
PM
To: Jiaying Liu;
birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] API change
request
Does
BIRT report designer explicitly set the units whenever it set the value for a
report elements' size property?
Can
others develop a custom report designer that does not set the unit? In
such a usage, is report level "unit" property useful?
From:
birt-dev-bounces@xxxxxxxxxxx on behalf of Jiaying Liu
Sent: Mon 3/26/2007 10:07
PM
To: birt-dev@xxxxxxxxxxx
Subject: [birt-dev] API change
request
There is a
bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=174259,
General settings for "Units" is ignored.
Since the Designer will decide the default units for each kind of element and
it takes higher priority, the one user setting on the report looks ignored.
Now propose to remove the ‘unit’ property from ReportDesign in ROM, and
corresponding API, to avoid confusion.
Best regards,
Jiaying Liu
Actuate Corporation - Shanghai R&D Center
( : (86)21-58826388