+1 for removing the
report/module level unit setting in BIRT report designer UI.
If we are
going to remove the default unit from module handle in model, shall we also
remove it from the session handle? Since both unit properties will
not apply to all element sizes, such as width and font can not share the same
unit.
Yes, BIRT
report designer explicitly set the units whenever it set the value for a report
element’s dimension property.
If others
develop a custom report designer that does not set the unit, the default unit of
this element defined in ROM will take effect. If it is not defined in ROM, then
the one setting on session handle will take effect. Otherwise, a semantic
warning will be thrown. (A dimension value without unit may cause failure when
engine render the report in html and pdf)
If we
remove this property from module, then user can not set general units for a
single module any more, he/she could just set the units on session, or on
individual design element.
Even now,
the general unit is not always suitable for all kinds of elements, for example,
if user set unit to be “mm”, but “mm” is not a common unit for font size. So ROM
defines some default units for those that suppose to have their own default
value. The default unit search route is:
ROM
Module
Session
The bug reporter thinks there should be a switch to decide either to use the metric system or the US/English system. But the unit he/she setting on module does not take effect since BIRT report designer has explicitly set units for elements. To avoid confusion, Qiangsheng suggests deprecating this property.
Best
regards,
Jiaying
Liu
Actuate
Corporation - Shanghai R&D Center
( :
(86)21-58826388
-----Original
Message-----
From: Wenfeng Li
Sent: Tuesday, March 27, 2007
2:36 PM
To: Jiaying Liu;
birt-dev@xxxxxxxxxxx
Subject:
RE: [birt-dev] API change request
Does BIRT
report designer explicitly set the units whenever it set the value for a report
elements' size property?
Can others develop a
custom report designer that does not set the unit? In such a usage, is
report level "unit" property useful?
From:
birt-dev-bounces@xxxxxxxxxxx on behalf of Jiaying Liu
Sent: Mon 3/26/2007 10:07 PM
To: birt-dev@xxxxxxxxxxx
Subject: [birt-dev] API change
request
There is a bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=174259,
General settings for "Units" is ignored.
Since the Designer will decide the
default units for each kind of element and it takes higher priority, the one
user setting on the report looks ignored.
Now propose to remove the ‘unit’
property from ReportDesign in ROM, and corresponding API, to avoid
confusion.
Best
regards,
Jiaying
Liu
Actuate
Corporation - Shanghai R&D Center
( :
(86)21-58826388