RE: [birt-dev] Request for patch review for Bugzilla 176874

["Scott Rosenbaum" <scottr@xxxxxxxxxxxxxxxxxxxxx>]

Dan,

The Eclipse Foundation sets the bar fairly high in terms of adding code to
the product.  The code has to be Eclipse worthy on the basics, the code
runs, we have appropriate tests, maintains API's, etc.  There are also
additional rules in terms of the code has to be submitted through
appropriate channels, it has to meet the intellectual property requirements,
etc.  

We really appreciate your contribution, we just need to do a bit more work
before we can throw it into our platform.

Thanks for the contribution,

Scott Rosenbaum


-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On
Behalf Of Wenfeng Li
Sent: Wednesday, March 14, 2007 11:31 PM
To: Daniel John Debrunner; birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] Request for patch review for Bugzilla 176874

Dan,

It means a committer is reading the contributed code.   

wenfeng

-----Original Message-----
From: "Daniel John Debrunner" <djd@xxxxxxxxxxxxxx>
To: "birt-dev@xxxxxxxxxxx" <birt-dev@xxxxxxxxxxx>
Sent: 3/14/07 8:06 PM
Subject: Re: [birt-dev] Request for patch review for Bugzilla 176874

Wei Yan wrote:
> We are reviewing it.

That's great that people are reviewing patches but what does "we are 
reviewing it" mean? Is some discussion happening in some other mailing 
list or forum, where can I follow this discussion?

Thanks,
Dan.

> 
> Thanks.
> 
> -Wei Yan
> 
> 
> -----Original Message-----
> From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx]
> On Behalf Of Deepa Remesh
> Sent: Wednesday, March 14, 2007 7:38 AM
> To: birt-dev@xxxxxxxxxxx
> Subject: [birt-dev] Request for patch review for Bugzilla 176874
> 
> Hi,
> 
> I have submitted a patch for Bugzilla 176874 which removes the call to
> setupRenderOption method from RunTask flow.
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=176874
> 
> A review/commit of this patch, if okay, would be most appreciated.


_______________________________________________
birt-dev mailing list
birt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/birt-dev
_______________________________________________
birt-dev mailing list
birt-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/birt-dev