Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [birt-dev] Which codeline to use for patch contributions?

Title: Message
Hi, Susan
 
Thanks for the contribution to the Chart documentation https://bugs.eclipse.org/bugs/show_bug.cgi?id=169492 .
 
 
1) To contribute a patch to the most recent version of the BIRT source do we check out
the source from the Head?  For example, /cvsroot/birt > HEAD > source?
or
Should we check it out from  /cvsroot/birt > Versions > source > source BIRT_2_2_X latest?
 
[wli] Please check out the HEAD version. 
 
2) How can I contribute a patch to an already released version of BIRT, or a release candidate of BIRT?
For instance, for a bug that has been fixed in 2.2, but exists in 2.1.1 and 2.1.2 which version of BIRT do we check out and create a patch for?  Can patches be back ported?  If so, how?
 
[wli] Bugs can be backported to previous release streams.  release stream is created for each 2nd digit release.  For example 2.1.x release stream, 2.2.x release streams.  It is possible to back port bug fixed in 2.2 to 2.1.2 but not 2.1.1, since the latest release vehicle for the 2.1.x stream is 2.1.2.   However, such back port will also depends on the risk and scope of changes on the code base.  The committer for the related component will evaluate the risk of back porting a bug.   When a committer decide to backport a bug, he/she will check into that target release CVS stream, and update the tag and map files to include the fix in next build on that stream (the 2.1.2 stream for example).
 
 
3) When contributing a patch, is it necessary to note in the bugzilla entry which version of BIRT the patch was created from? (Especially in the case above.)
 
[wli] yes, please set the target milestone to that release, and if the fix is for multiple release, please set the target release to the latest one, but also put in comment all release stream that needs this fix.
 
4) Is it a requirement to run all JUnit tests against any patch submitted?  Against some patches?
How is this determined?
 
[wli] It is recommended to test as much as you can with you patch.  But the committer(s) who reviews and checks in the patch will also run the unit tests he/she has before check in.  Frequently, they might also revise the patch before check in.
 
Wenfeng
 
-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Susan Cline
Sent: Tuesday, January 09, 2007 2:25 PM
To: birt-dev@xxxxxxxxxxx
Subject: [birt-dev] Which codeline to use for patch contributions?

Hi,
 
I have some questions about contributing patches to the BIRT source.  I can not find answers to these on the BIRT web site, wiki or in the newsgroup.  If I have overlooked this information, please let me know where I can find it.
 
The instructions on the website explain about building BIRT from CVS, and apply to the 2.1.1 version, but don't mention which version of BIRT should be used for creating patches. 
 
1) To contribute a patch to the most recent version of the BIRT source do we check out
the source from the Head?  For example, /cvsroot/birt > HEAD > source?
or
Should we check it out from  /cvsroot/birt > Versions > source > source BIRT_2_2_X latest?
 
2) How can I contribute a patch to an already released version of BIRT, or a release candidate of BIRT?
For instance, for a bug that has been fixed in 2.2, but exists in 2.1.1 and 2.1.2 which version of BIRT do we check out and create a patch for?  Can patches be back ported?  If so, how?
 
3) When contributing a patch, is it necessary to note in the bugzilla entry which version of BIRT the patch was created from? (Especially in the case above.)
 
4) Is it a requirement to run all JUnit tests against any patch submitted?  Against some patches?
How is this determined?
 
I'd be happy to create a wiki page with this information if someone can answer these questions.
 
Regards,
 
Susan

Back to the top