Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev]CheckIn: Fix Bugzilla Bug --- 123290 inconsistent styles with concurrent report requests

Title: [birt-dev]CheckIn: Fix Bugzilla Bug --- 123290 inconsistent styles with concurrent report requests

Summary 

Bugzilla Bug (s) Resolved:
123290 inconsistent styles with concurrent report requests
Description:
ENGINE use CSSParser to parse the CSS properties which includes:
Styles in HTML, styles in ROM, styles setted through java-script's.

As the CSSParser (CSSEngine) is not thread safe, the style may be corrupt when running concurrrently.

Then ENGINE's API defines that each task should be only used in a single thread, so create the CSSEngine for each task. That can fix this issue.

 
Test Description:
Unit Test/Manul Test
 
Files Edited:
cvs ci -m "create CSSEngine for each report as the CSSEngine is not thread safe" -l "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/DataContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/AbstractContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/ir/Report.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/ReportContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/TextContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/engine/BIRTCSSEngine.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/CellContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/AreaStyle.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/parser/EngineIRVisitor.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/engine/CSSStylableElement.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentReader.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/css/CSSPaserTest.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/presentation/ReportContentReaderWriterTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/ComputedStyle.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/CellComputedStyle.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/TableContent.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/content/ReportContentReaderAndWriterTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/PageContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/TableBandContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/AbstractStyle.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/StyleDeclaration.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/ForeignContent.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/css/dom/StyleDeclarationTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentLoader.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/ContainerContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/LabelContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/RowContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/IReportContent.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/content/impl/ImageContent.java"

***
cvs ci -m "create CSSEngine for each report as the CSSEngine is not thread safe" -l "/org.eclipse.birt.report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/layout/util/HTMLStyleProcessor.java" "/org.eclipse.birt.report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/layout/area/impl/AbstractArea.java" "/org.eclipse.birt.report.engine.emitter.pdf/src/org/eclipse/birt/report/engine/layout/util/HTML2Content.java"

Files Added:

Notes to Build Team:
 
Notes to Developers:

Notes to QA:
 
Quotes to Documentation:


-Wei Yan




Back to the top