Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[birt-dev]CheckIn: Fix Bugzilla Bug --- 119124 Something wrong with page number

Title: [birt-dev]CheckIn: Fix Bugzilla Bug --- 119124 Something wrong with page number

Summary 

Bugzilla Bug (s) Resolved:
119124 Something wrong with page number

Description:
Why:
        While change the page number start from 1, forgeting to change the page number in load page hint. So it always forget the last page.

Fix:
        Change the page number start from 1 in loadPageHint.

1) remove the open() from document reader, document writer, content reader, content writer as the object is opened after created.

2) change the openTOCEntry() to startTOCEntry()
3) remove the EOF exception process from the content loader as EOF exception is never throw out for RAInputStream.


 
Test Description:
Unit Test (Create the report document, load the report document, the created page number is equals to predefined one)


Files Edited:
cvs ci -m "1) fix bug 119124,
2) remove open() from document reader, content reader, document writer, content writer(the objec is opened after created),

3) create different data engine based on document, document writer." -l "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/api/TOCTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentLoader.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/impl/RunTask.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/impl/ReportDocumentReader.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/impl/ReportDocumentWriter.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/api/IReportDocument.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/toc/TOCBuilderTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/data/DataEngineFactory.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentReader.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentConstants.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportContentWriter.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/presentation/ReportContentReaderWriterTest.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/presentation/ReportDocumentEmitter.java"

Files Added:

Notes to Build Team:
 
Notes to Developers:

Notes to QA:
 
Quotes to Documentation:


-Wei Yan




Back to the top