| [birt-dev]CheckIn: Fix Bugzilla Bug --- 116763, 116545 Unit test failed in ENGINE |
Description:
Unit test failed in ENGINE.
1) ListingDesign --> Model deprecated the onStart, onFinish and onRow, it returns NULL even if the design has those properties
2) cssText --> CSS standard defines that all string property must quoted by " or '. For BIRT properties such as string-format, number-format which are string properties doesn't including the quotes. Remove the quotes from the value.getCssText, but add the quote in style.getCssText. The result is:
in the design file, without quotes
in the script get/set, without quotes
for test (css standard syntax), need the quotes
3) mutliple executor --> for the mutliline text, if the text type is plain-text, we can't use plain/text to handle it as it should to be formated. It should act as DataItem. So change the raw type from text/plain to binary/value.
Regression: Yes/No
No
Code Owner:
Shanghai Engine Team
Code Reviewers:
Shanghai Engine Team
Tests:
Unit test
Test Automated: Yes/No (if “No”, then explain why)
Yes
Branches Involved:
Eclipse CVS
Defect Entries Resolved:
116763
116545
Case Entries Resolved:
None
Notes to Developers:
None
Notes to QA:
None
Notes to Documentation:
None
Notes to Configuration Management:
None
Notes to Support:
None
Notes to Product Marketing:
None
cvs ci -m "fix unit test errors" -l "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/parser/EngineIRVisitor.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/engine/value/ListValue.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/engine/value/IdentifierManager.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/executor/multiline.txt" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/css/dom/AbstractStyle.java" "/org.eclipse.birt.report.engine/src/org/eclipse/birt/report/engine/ir/ListingDesign.java" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/css/style.txt" "/org.eclipse.birt.report.engine/test/org/eclipse/birt/report/engine/parser/ListDesignTest.java"
-Wei Yan