Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [birt-dev] BIRT API Change Request -- new feature fordynamicandcascading parameters

Title: Message
OK, I will use paramValueType instead
 
Thanks
Rock Yu
Actuate Corporation - Shanghai R&D Center
Phone:(86)21-20270900 Ext 229
Email: cyu@xxxxxxxxxxx

-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of
Wenfeng Li
Sent: Wednesday, September 28, 2005 4:42 AM
To: For developers on the BIRT project
Subject: RE: [birt-dev] BIRT API Change Request -- new feature fordynamicandcascading parameters

 

I agree that it is preferable to keep paramType and add a new choice of  valueType, or paramValueType.

 

Wenfeng

-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx]On Behalf Of Rima Kanguri
Sent: Tuesday, September 27, 2005 12:12 PM
To: For developers on the BIRT project
Subject: RE: [birt-dev] BIRT API Change Request -- new feature for dynamicandcascading parameters

Rock,

 

Why dont we add new valueType ( static, dynamic )

and keep paramType ( string/float/datetime/decimal/boolean)

That way we maintain DE API compatibility

 

Thanks

--Rima

-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx]On Behalf Of Chenzhong Yu
Sent: Monday, September 26, 2005 11:44 PM
To: birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] BIRT API Change Request -- new feature for dynamic andcascading parameters

Wenfeng,

 

The change may break the application logic that uses DE API. The original choice paramType (string/float/datetime/decimal/boolean)

is changed to paramDataType. And another choice paramType (static/dynamic) is added. If an outside user used the original paramType

constants and did some choice value comparison. His logic may be broken. 

 

Besides this constants,  methods won't be impacted.

 

While this change is necessary, I will document the constants in the code as clear as possible to notify the user of the change.

 

(The change doc has been refined using standard template)

 

 

Thanks

Rock Yu

Actuate Corporation - Shanghai R&D Center

Phone:(86)21-20270900 Ext 229

Mobile: 13061712090

Email: cyu@xxxxxxxxxxx

-----Original Message-----
From: birt-dev-bounces@xxxxxxxxxxx [mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wenfeng Li
Sent: Tuesday, September 27, 2005 1:39 PM
To: For developers on the BIRT project; birt-dev@xxxxxxxxxxx
Subject: RE: [birt-dev] BIRT API Change Request -- new featurefordynamicandcascading parameters

 

Rock,

Understand the file format will not be an issue.   At the API level,  will the change break application that uses DE API?  If so,  which interface and method will be impacted?  If we have to make this change,  we will need to document the interface/method that is going to be impacted.

Regards,

Wenfeng


 -----Original Message-----
From:   Chenzhong Yu [mailto:cyu@xxxxxxxxxxx]
Sent:   Mon Sep 26 19:45:18 2005
To:     birt-dev@xxxxxxxxxxx
Subject:        RE: [birt-dev] BIRT API Change Request -- new feature fordynamicandcascading parameters

The paramType is a choice name, it will not be written into the design
file.

In ROM, the original property definition:
<Property detailType="paramType"name="dataType" runtimeSettable="false"
since="1.0" type="choice">

is changed to:
<Property detailType="paramDataType" name="dataType"
runtimeSettable="false" since="1.0" type="choice">
    
Only the property name "dataType" and the choice value will be written
into the design file, like:
<property name="dataType">dataTime</property>

In API level, only the static choice name member name will be changed. I
will refactory them all before I check in the code.

(The reason I change the choice name is that we introduced another more
senseful "paramType" choice name used to tell
whether a parameter is static or dynamic. )

Thanks

Rock Yu
Actuate Corporation - Shanghai R&D Center
Phone:(86)21-20270900 Ext 229
Mobile: 13061712090
Email: cyu@xxxxxxxxxxx

        -----Original Message-----
        From: birt-dev-bounces@xxxxxxxxxxx
[mailto:birt-dev-bounces@xxxxxxxxxxx] On Behalf Of Wenfeng Li
        Sent: Tuesday, September 27, 2005 2:10 AM
        To: For developers on the BIRT project
        Subject: RE: [birt-dev] BIRT API Change Request -- new feature
for dynamicandcascading parameters

        

        

        Rock

        

       
  
        

        Regards

        Wenfeng Li
        PMC Lead
        Eclipse Business Intelligence & Reporting Tools Project
        <http://www.eclipse.org/birt/>

         -----Original Message-----
        From: birt-dev-bounces@xxxxxxxxxxx
[mailto:birt-dev-bounces@xxxxxxxxxxx]On Behalf Of Chenzhong Yu
        Sent: Sunday, September 25, 2005 11:28 PM
        To: birt-dev@xxxxxxxxxxx
        Subject: [birt-dev] BIRT API Change Request -- new feature for
dynamic andcascading parameters

                <<API change control doc(Feature-cascading and dynamic
parameters).doc>>
                Model will checkin support for dynamic and cascading
parameters. The attachment is the change document.
                Please review it.

                Rock Yu
                Actuate Corporation - Shanghai R&D Center
                Phone:(86)21-20270900 Ext 229
                Mobile: 13061712090
                Email: cyu@xxxxxxxxxxx


Back to the top