Re: [babel-dev] please review patch on bug 221181, 470121 and 481655

[Satoru Yoshida <raamat@xxxxxxxxxxxxxxxxx>]

Thank You, Denis.

I will commit and push the patches,
 then try the Gerrit in further improvement for Babel.

Thank You.
Satoru Yoshida

----- Denis Roy <denis.roy@xxxxxxxxxxx> Wrotes:
>Excellent.
>
>Satoru, I have reviewed all your patches.  Thank you, I think all is good.
>
>Denis
>
>
>On 11/11/2015 02:55 PM, Kit Lo wrote:
>> Let's try that!
>> 
>> Thanks!
>> 
>> Kit Lo
>> Eclipse Babel Project Lead
>> IBM Eclipse SDK (IES) Globalization Technical Lead
>> IBM Rational solution for Collaborative Lifecycle Management (CLM)
>> Globalization Technical Lead
>> 
>> Inactive hide details for Denis Roy ---11/11/2015 09:12:27 AM---Yes,
>> that is Gerrit Code review. I suggest we review & merge yoDenis Roy
>> ---11/11/2015 09:12:27 AM---Yes, that is Gerrit Code review. I suggest
>> we review & merge your patches then do the switch.
>> 
>> From: Denis Roy <denis.roy@xxxxxxxxxxx>
>> To: babel-dev@xxxxxxxxxxx
>> Date: 11/11/2015 09:12 AM
>> Subject: Re: [babel-dev] please review patch on bug 221181, 470121 and
>> 481655
>> Sent by: babel-dev-bounces@xxxxxxxxxxx
>> 
>> ------------------------------------------------------------------------
>> 
>> 
>> 
>> Yes, that is Gerrit Code review.
>> 
>> I suggest we review & merge your patches then do the switch.
>> 
>> I will walk us through the process.
>> 
>> Kit, do you agree or object?
>> 
>> Denis
>> 
>> 
>> 
>> 
>> On 11/10/2015 09:55 AM, Satoru Yoshida wrote:
>>> Hello, Denis.
>>>
>>> Does the Gerrit code review mean following web site ? :)
>>> example)
>>> https://git.eclipse.org/r/#/q/status:open
>>> https://git.eclipse.org/r/#/c/60031/
>>>
>>> Thank You
>>> Satoru Yoshida
>>>
>>> ----- Denis Roy <denis.roy@xxxxxxxxxxx>wrotes:
>>>>
>>>>
>>>> On a completely unrelated note, I think we should use Gerrit Code
>> review.  It is super easy and makes code review MUCH easier than what we
>> are currently doing.
>>>> Kit, Satoru, do you want to try?
>>>>
>>>>
>>>> --Denis Roy @droy_eclipsehttp://eclipse.org/
>>>>
>>>> -------- Original message --------
>>>> From: Satoru Yoshida <raamat@xxxxxxxxxxxxxxxxx>
>>>> Date: 2015-11-09  4:53 PM  (GMT-05:00)
>>>> To: Babel committers mailing list <babel-dev@xxxxxxxxxxx>
>>>> Subject: [babel-dev] please  review patch on bug 221181, 470121 and
>> 481655
>>>>
>>>> Hello, Denis and Kit.
>>>> I will feel happy if you review patch on bug 221181, 470121 and 481655.
>>>>
>>>> [221181] Search a specific string
>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=221181
>>>>
>>>> [470121] (Reopen) scoreboard could be removed if no needed
>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=470121
>>>>
>>>> [481655] jumpto.js and search.js do not exist.
>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=481655
>>>>
>>>> I will make tag on pushed file in Git repository
>>>> if reviewed successfully. :)
>>>>
>>>> Thank You.
>>>> Satoru Yoshida
>>>> _______________________________________________
>>>> babel-dev mailing list
>>>> babel-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/babel-dev
>>>
>>> _______________________________________________
>>> babel-dev mailing list
>>> babel-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or
>> unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/babel-dev
>>>
>> _______________________________________________
>> babel-dev mailing list
>> babel-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/babel-dev
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> babel-dev mailing list
>> babel-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/babel-dev
>> 
>_______________________________________________
>babel-dev mailing list
>babel-dev@xxxxxxxxxxx
>To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>https://dev.eclipse.org/mailman/listinfo/babel-dev
>