Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [babel-dev] About deleted files and their plugin id

On Tue, Nov 18, 2008 at 4:10 PM, Kit Lo <kitlo@xxxxxxxxxx> wrote:

Is it easy to identify those files in the DB? If yes, it'd be nice to remove them (option 2). That will trim down the DB and reduce backup storage too (not sure if that's much).
DELETE * from files where plugin_id = ""; 


If there is no safe and easy way, option 3 is okay with me too.

Well, the problem is that next time around a file is deleted in the DB, you won't know about it. And you will keep asking people for translations about them, and add them to the fragments. 


Kit Lo
IBM Eclipse SDK Globalization Technical Lead
Eclipse Babel Project Co-lead



"Antoine Toulme" <antoine@xxxxxxxxxxxxxxx>
Sent by: babel-dev-bounces@xxxxxxxxxxx

11/18/2008 09:08 AM

Please respond to
antoine@xxxxxxxxxxxxxxx; Please respond to
Babel committers mailing list <babel-dev@xxxxxxxxxxx>

To
"Babel committers mailing list" <babel-dev@xxxxxxxxxxx>
cc
Subject
[babel-dev] About deleted files and their plugin id





Hi all,

I have some pending changes for the generate1.php script.

In this script, we used to use the plugin id as found by doing a regular _expression_ on the file path.

I made sure that, when processing map files, we would pick up the plugin id and put it in the DB.

The problem is that some files have been deleted since they had been added to the files table. Those files have no plugin_id.

A bug[0] was opened regarding this.

The bug presents three options:

1. Just don't generate for those files.
2. Remove them from the DB.
3. Flag those files as non existing during the processing and avoid generating
for them.

I just added a workaround: use the old fashion way of processing by grabbing the plugin id from the file path. Of course this would break on the Intalio machine, but we can maybe fix this during the generate1.php refactoring later.

We still need to do something about deleted files. Pick an option, I vote for 3.

Thanks,

Antoine

[0]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=254429

--

http://www.lunar-ocean.com/blog
_______________________________________________
babel-dev mailing list
babel-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/babel-dev




--
http://www.lunar-ocean.com/blog


Back to the top