[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [aspectj-users] No warning for class not found in parameter type

I wonder if something could be done in AJDT to highlight things, such as a decoration for libs, packages and classes to indicate which are and aren't on the inpath.
 
I can't see this working unless the inpath projects were all AJDT enabled, which is something I try to avoid.
 
This is something that would be easier to browse in the Problems/Markers view once the Info messages have accurate resource/line number info.
 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=268309
 
 

From: aspectj-users-bounces@xxxxxxxxxxx [mailto:aspectj-users-bounces@xxxxxxxxxxx] On Behalf Of Andy Clement
Sent: 13 March 2009 20:14
To: aspectj-users@xxxxxxxxxxx
Subject: Re: [aspectj-users] No warning for class not found in parameter type

Hi Kevin,

So there were classes with the join points in on the classpath that needed promoting to the inpath?  To put out a warning, wouldn't AspectJ have had to completely analyse everything on the classpath for potential join points to see if this kind of mistake had been made?  That would be rather expensive I think.  I guess that is one reason why the inpath exists in the first place, so that we don't analyse/weave more classes than necessary.  I can see it was awkward to debug for you, I'm just having trouble working out what AspectJ could do better that wouldn't kill performance.

cheers,
Andy.

2009/3/11 Kevin Roll <kroll@xxxxxxxxxxxx>
I just spent hours tracking down a problem which turned out to be a peculiarity in AspectJ. I have a pointcut

       pointcut setter(PropertyChangeSupported b): execution(void set*(*)) && this(b);

which I use to pick out setters of a bean. The advice that uses this pointcut was not being applied when the parameter to the method was a non-primitive type. After much investigation I determined that the classes at issue were not specified in the inpath; adding them solved the problem. I use a tightly controlled inpath to minimize the amount of time that the AspectJ compiler spends when running. The behavior of simply ignoring those methods was very unexpected to me; it seems that some sort of warning should have been issued. Thoughts?

_______________________________________________
aspectj-users mailing list
aspectj-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-users

**********************************************************************
IMPORTANT NOTICE.
Confidentiality:  This e-mail and its attachments are intended for the above named only and may be confidential.  If they have come to you in error you must take no action based on them, nor must you copy or show them to anyone; please reply to this e-mail and highlight the error.
Security Warning:  Please note that this e-mail has been created in the knowledge that Internet e-mail is not a 100% secure communications medium.
We advise that you understand and observe this lack of security when e-mailing us.
Viruses:  Although we have taken steps to ensure that this e-mail and attachments are free from any virus, we advise that in keeping with good computing practice the recipient should ensure they are actually virus free.
Monitoring and Scanning:  Cambridge Cognition has monitoring and scanning systems in place in relation to emails sent and received to: monitor / record business communications; prevent and detect crime; investigate the use of the Company's internal and external email system; and provide evidence of compliance with business practices.

Cambridge Cognition Limited
Company Registration Number 4338746
Registered address:
Tunbridge Court
Tunbridge Lane
Bottisham
Cambridge
CB25 9TU
UK
**********************************************************************