[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [aspectj-users] AspectJ5 and hot code replacement

New version of that patch added to the bug report.

Andy.

2008/5/13 Andy Clement <andrew.clement@xxxxxxxxx>:
> I will double check the patch in a few mins and update the version on
>  that bug, i could well have
>  messed it up, I have no way to test what I was changing :)
>
>  cheers,
>  Andy.
>
>  2008/5/13 Thiago Souza <tcostasouza@xxxxxxxxx>:
>
>
> > Hi,
>  >
>  >     I tried your patch but It didn't work for me. I'm using aspectj
>  >  1.6.0 and when code changes it still warns me with:
>  >
>  >  java.lang.Exception: AspectJ5 does not weave hotswapped class (xxxxxxxxx)
>  >         at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform(ClassPreProcessorAgentAdapter.java:55)
>  >         at sun.instrument.TransformerManager.transform(TransformerManager.java:169)
>  >         at sun.instrument.InstrumentationImpl.transform(InstrumentationImpl.java:365)
>  >
>  >    The content of patch.zip is the
>  >  org.aspectj.weaver.loadtime.ClassPreProcessor class only, is this
>  >  right? Shouldn't it be at least a patch at
>  >  org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter?
>  >
>  >    I followed the instructions on your comment at the bug, is there
>  >  anything else to do?
>  >
>  >  Regards,
>  >  Thiago Souza
>  >
>  >
>  >
>  >  On Tue, May 13, 2008 at 2:15 PM, Thiago Souza <tcostasouza@xxxxxxxxx> wrote:
>  >  > Thanks, I'll check it and let you know of any problems
>  >  >
>  >  >
>  >  >
>  >  >  On Mon, May 12, 2008 at 8:31 PM, Andy Clement <andrew.clement@xxxxxxxxx> wrote:
>  >  >  > Please take a look at the enhancement request for this:
>  >  >  >  https://bugs.eclipse.org/bugs/show_bug.cgi?id=120375
>  >  >  >
>  >  >  >  In comment #7 I attached a patch that can be applied to a recent
>  >  >  >  weaver jar to remove the restriction - however
>  >  >  >  I have put nothing into the codebase as yet as I'm waiting on feedback
>  >  >  >  on how it behaves.
>  >  >  >
>  >  >  >  cheers,
>  >  >  >  Andy.
>  >  >  >
>  >  >  >  2008/5/12 Thiago Souza <tcostasouza@xxxxxxxxx>:
>  >  >  >
>  >  >  >
>  >  >  > > Hi,
>  >  >  >  >
>  >  >  >  >     We've been using AspectJ5 through Java5 LTW, but unfortunately,
>  >  >  >  >  we've lost the hot code replacement feature that's very import during
>  >  >  >  >  development journeys (new code is not loaded with aspectj saying that
>  >  >  >  >  "AspectJ5 does not weave hotswapped class"). Is there any way to do
>  >  >  >  >  hot code replacement with LTW? (I've tried different ways, even with
>  >  >  >  >  WeavingURLClassLoader with no success)
>  >  >  >  >
>  >  >  >  >  Regards,
>  >  >  >  >  Thiago Souza
>  >  >  >  >  _______________________________________________
>  >  >  >  >  aspectj-users mailing list
>  >  >  >  >  aspectj-users@xxxxxxxxxxx
>  >  >  >  >  https://dev.eclipse.org/mailman/listinfo/aspectj-users
>  >  >  >  >
>  >  >  >  _______________________________________________
>  >  >  >  aspectj-users mailing list
>  >  >  >  aspectj-users@xxxxxxxxxxx
>  >  >  >  https://dev.eclipse.org/mailman/listinfo/aspectj-users
>  >  >  >
>  >  >
>  >  _______________________________________________
>  >  aspectj-users mailing list
>  >  aspectj-users@xxxxxxxxxxx
>  >  https://dev.eclipse.org/mailman/listinfo/aspectj-users
>  >
>