[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [aspectj-users] Very Slow Fields Cut
|
Andy ,I'm not getting the same results with the new casting. I'm still
getting the same performance. I would love if I get SuperCar to run at 50%
of Car.
public privileged aspect SuperObjectController{
pointcut getProperty(SuperObject o): this(o) && get(@SuperProperty int
*) && target(SuperObject+);
^ I also added this
int around(SuperObject o): getProperty(o) {
return proceed(o);
}
pointcut setProperty(SuperObject o,int v): this(o) && args(v) &&
set(@SuperProperty * *) && target(SuperObject+) ;
void around(SuperObject o,int v): setProperty(o,v) {
proceed(o,v);
}
}
/////////////////////////////////////////////
Super:173
Normal:69
Non-Direct:121
Super:216
Normal:51
Non-Direct:155
Super:202
Normal:45
Non-Direct:118
Which version are you using ?
Andy Clement wrote:
>
> It did not, and i was surprised too. But with the removal of the cast
> the performance is back where it should be so I didn't investigate
> further.
>
> cheers,
> Andy.
>
> 2008/5/9 Eric Bodden <eric.bodden@xxxxxxxxxxxxxx>:
>>> Even
>>> though you are only doing proceed() from your advice at the moment,
>>> the code is all in place for obtaining the aspect instance at each
>>> join point and then invoking the advice.
>>
>> Andy, just out of curiosity:
>>
>> Does ajc not actually inline such simple pieces of around-advice?
>> Actually I thought so, and if it does I am surprised that there's
>> still that much overhead.
>>
>> Eric
>>
>> --
>> Eric Bodden
>> Sable Research Group
>> McGill University, Montréal, Canada
>> _______________________________________________
>> aspectj-users mailing list
>> aspectj-users@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>>
> _______________________________________________
> aspectj-users mailing list
> aspectj-users@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/aspectj-users
>
>
--
View this message in context: http://www.nabble.com/Very-Slow-Fields-Cut-tp17139141p17158927.html
Sent from the AspectJ - users mailing list archive at Nabble.com.