aspectj-users http://dev.eclipse.org/mhonarc/lists/aspectj-users/maillist.html aspectj-users en-us Mon, 21 May 2012 16:30:53 GMT Mon, 21 May 2012 16:30:53 GMT http://blogs.law.harvard.edu/tech/rss MHonArc RSS 2.0 RCFile webmaster@eclipse.org (Webmaster) webmaster@eclipse.org (Webmaster) aspectj-users http://www.eclipse.org/eclipse.org-common/themes/Phoenix/images/eclipse_home_header.jpg http://dev.eclipse.org/mhonarc/lists/aspectj-users/maillist.html [aspectj-users] Accessing protected methods of parent class from within an aspect in another package http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13547.html Hi there.I have Parent class and a child one. The parent class has some protected methods.My pointcut works on methods of the child class. The problem is that I want to access protected methods of the parent in my Aspect, but they are notbsp;visible from ... Hi there.

I have Parent class and a child one. The parent class has some protected  methods.
My pointcut works on methods of the child class. The problem is that I want to access protected methods of the parent in my Aspect, but they are not 
visible from within my Aspect.

All these 3 classes (Parent, Child, Aspect) are in different packages. 

I read here http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg03270.html
that using privileged  modifier will solve the problem but it does not work for me.
Any idea??

Sina
]]> Mon, 21 May 2012 16:25:30 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13547.html my.linked.account@xxxxxxx (Sina) [aspectj-users] Fwd: trigger all calls/sets from an annotated parameter within a method http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13546.html Hi all,I'm trying to trigger all calls/sets from an annotated parameter within a method. Consider the following example:public class A {       public void foo(@MyAnno B b1, B b2){         b1.bar();         //this should trigger      A0;  b1.field = 42;0; /...

I'm trying to trigger all calls/sets from an annotated parameter within a method. Consider the following example:

public class A {
   
    public void foo(@MyAnno B b1, B b2){
        b1.bar();         //this should trigger
        b1.field = 42;  //this should trigger
       
        b2.bar();         //should not trigger
        b2.field = 42;  //should not trigger
    }
}

public class B {
    public int field;
    public void bar() {    }
}

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.PARAMETER)
public @interface MyAnno {
}


So far I have the following aspect. But of course this triggers all calls and sets from all method parameters.

@Aspect
public class MyAspect {
    @Before("cflowbelow(execution(* *.*(..,@MyAnno (*),..))) && (call(* *(..)) || set(* *)) && !within(MyAspect)")
    public void belowAdvice() {
        System.out.println("triggered");
    }
}

Is there any way to only trigger the calls and sets from the annotated (in my case b1) parameter within a method (foo())?


Thanks in advance!

Fred

]]> Mon, 21 May 2012 15:50:52 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13546.html frederick.egli@xxxxxxx (Frederick Egli) [aspectj-users] Issue with WAR file http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13545.html Hello, We have a problem and we tried to figure out if this problem can be solved by iajc. We have WAR file which contains the source and the @aspectJ files. We use the ANT command <iajc> inpath="my_original_War" -outJar="MyWaruot; - classpath="The full l... Hello,

We have a problem and we tried to figure out if this problem can be solved by iajc. We have WAR file which contains the source and the @aspectJ files.
We use the ANT command  <iajc> inpath="my_original_War" -outJar="MyWar" - classpath="The full list of jar"

The weaven did not report any error, everything seems fine. BUT, when we  tried to run the WAR file inside the EAR, it fails. We compared the both WAR and the  WAR produced by the Weaver did not have the same structure as the original WAR.

The WAR has an additional folder starting from the root : com\companyName\projectName\.... In fact, the weaver have put the src folder at the root of the WAR file instead of keeping the classes inside WEB-INF\classes. It it like having duplicated classes, with and without veaven.

For sure, it is not normal ?
Iis there a way to specify with IAJC  the destination folder where to put the weaven classes inside the WAR (I think, there are weaven classes ?)

What are our alternatives ?

Best regards and thank you for your quick feedback.

JA.

=============================================
The exact command for the weaver
=============================================

           <iajc inpath="Web_origine.war"
                    outjar="Web.war"
                 showWeaveInfo="false">        
                   <classpath>
                           <pathelement path = "ext/aspectjrt.jar"/>
                           <pathelement path = "ext/javax.faces.jar"/>
                           <pathelement path = "ext/annotations-4.2.0.Final.jar"/>
                           <pathelement path = "ext/antlr-2.7.6.jar"/>
                           <pathelement path = "ext/cglib-nodep-2.2.2.jar"/>
                           <pathelement path = "ext/cof-service-api-official.jar"/>
                           <pathelement path = "ext/cof-service-web-official.jar"/>
                           <pathelement path = "ext/common-api-core-official.jar"/>
                           <pathelement path = "ext/common-api-dm-official.jar"/>
                           <pathelement path = "ext/common-api-email-official.jar"/>
                           <pathelement path = "ext/common-api-il-services-official.jar"/>
                           <pathelement path = "ext/common-api-java-services-official.jar"/>
                           <pathelement path = "ext/common-api-moneris-official.jar"/>
                           <pathelement path = "ext/common-api-pega-services-official.jar"/>
                           <pathelement path = "ext/common-api-web-official.jar"/>
                           <pathelement path = "ext/common-api-web-struts-official.jar"/>
                           <pathelement path = "ext/common-api-web-tags-official.jar"/>
                           <pathelement path = "ext/common-api-wi-official.jar"/>
                           <pathelement path = "ext/commons-lang-2.4.jar"/>
                           <pathelement path = "ext/commons-logging-1.1.1.jar"/>
                           <pathelement path = "ext/commons-validator-1.4.0.jar"/>
                           <pathelement path = "ext/cssparser-0.9.6.jar"/>
                           <pathelement path = "ext/dom4j-1.6.1.jar"/>
                           <pathelement path = "ext/guava-11.0.1.jar"/>
                           <pathelement path = "ext/hibernate-3.3.2.jar"/>
                           <pathelement path = "ext/hibernate-annotations-3.4.0.jar"/>
                           <pathelement path = "ext/hibernate-commons-annotations-3.4.0.jar"/>
                           <pathelement path = "ext/hibernate-entitymanager-3.4.0.jar"/>
                           <pathelement path = "ext/hibernate-validator-4.2.0.Final.jar"/>                          
                           <pathelement path = "ext/junit-4.10.jar"/>
                           <pathelement path = "ext/log4j-1.2.16.jar"/>
                           <pathelement path = "ext/ojdbc14-10.2.0.4.jar"/>
                           <pathelement path = "ext/org.springframework.asm-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.beans-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.context-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.core-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework._expression_-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.jdbc-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.orm-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.transaction-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/org.springframework.web-3.0.6.RELEASE.jar"/>
                           <pathelement path = "ext/pop-api-official.jar"/>
                           <pathelement path = "ext/pop-services-official.jar"/>
                           <pathelement path = "ext/richfaces-components-api-4.2.0.Final.jar"/>
                           <pathelement path = "ext/richfaces-components-ui-4.2.0.Final.jar"/>
                           <pathelement path = "ext/richfaces-core-api-4.2.0.Final.jar"/>
                           <pathelement path = "ext/richfaces-core-impl-4.2.0.Final.jar"/>
                           <pathelement path = "ext/sac-1.3.jar"/>
                           <pathelement path = "ext/slf4j-api-1.6.4.jar"/>
                           <pathelement path = "ext/slf4j-log4j12-1.6.4.jar"/>
                           <pathelement path = "ext/j2ee.jar"/>
                           <pathelement path = "ext/commons-collections-3.2.1.jar"/>
                           <pathelement path = "ext/org.springframework.aop-3.0.6.RELEASE.jar"/>                          
                   </classpath>

                  </iajc>]]> Fri, 18 May 2012 16:50:11 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13545.html Jean.Andre@xxxxxxx (Jean Andre) Re: [aspectj-users] Aspect in an EAR file http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13544.html Yes, James is right, load time weaving can do the kinds of thing you want to do but it will incur you a startup hit. Using a javaagent each classloader in the system gets a weaver and will use any aop.xml files it can 'reach' through its classpath to configure itself. So if one jar on that classpath defines an aop.xml file containing an aspect, then that weaver associated with the classloader will apply the aspect to everything loaded through that same classloader. Weaving will be about the same speed regardless of when you choose to do it (compile time, post compile time, load time) but: - load time weaving will weave things as they are loaded. This may sound obvious, but this does mean if something isn't loaded on a particular run of the application then you won't weave it or incur the cost of weaving it. Whereas compile time weaving will weave everything. - beyond speed there is a memory overhead for a weaver that you will incur. But having said that we are including some basic caching in the next version that will mean you can weave on first startup, automatically store those woven entities, and then use the stored cached versions on the subsequent starts. (reducing the memory and performance impact). Andy On 18 May 2012 04:30, James Black <planiturthian@xxxxxxxxx> wrote: > I don't see why you can't do this, but you will take a performance hit as it > weaves at run time. > > It is best if you can apply the aspects during compilation, but if that > isn't an option then run time is your other option. > > On May 18, 2012 6:10 AM, "jbolger" <john.bolger@xxxxxxxxx> wrote: >> >> Hi, >> >> Can you tell me if I can configure an aspect within an EAR to apply advice >> against all code (including jars and wars) within the EAR and it's lib >> (without having to define the aspect in each of the wars)? >> >> Also in this case, which weaving style is most appropriate? Is it even >> possible to perform compile/post-compile time weaving for an EAR when the >> jars / wars it includes have already been built? >> >> And finally, is any weaving style more performant than the other? >> >> Thanks in advance, >> John >> >> -- >> View this message in context: >> http://aspectj.2085585.n4.nabble.com/Aspect-in-an-EAR-file-tp4644307.html >> Sent from the AspectJ - users mailing list archive at Nabble.com. >> _______________________________________________ >> aspectj-users mailing list >> aspectj-users@xxxxxxxxxxx >> https://dev.eclipse.org/mailman/listinfo/aspectj-users > > > _______________________________________________ > aspectj-users mailing list > aspectj-users@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/aspectj-users > ]]> Fri, 18 May 2012 16:06:27 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13544.html andrew.clement@xxxxxxx (Andy Clement) Re: [aspectj-users] Advice did not match http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13543.html I might need to see where you are applying it? I created this tiny thing and your aspect worked just fine: class Foo { @Updates void foo(String s) {} } The advice did not match indicates that during the build of the code containing the aspect it didn't find anything to apply it to. If that is because you are building it into an aspect library to use later, you can just ignore the warning. If you expected it to match something though - I'd need to see what it isn't matching. If it isn't matching you can break it into smaller pieces to determine which piece is causing the problem. cheers Andy On 17 May 2012 11:40, hart404 <hart404@xxxxxxxxx> wrote: > Can anyone tell me why I'm getting "Advice did not match" on the after advice > in the following code, please? > > package edu.uat.cs2011.observerpattern; > > import java.util.ArrayList; > import java.util.List; > > public aspect ObservableAspect { > >        declare parents: hasmethod(@Updates * *.*(..)) implements Observable; > >        private List<Observer> observers = new ArrayList<Observer>(); > >        public void addObserver(Observer observer) { >                observers.add(observer); >        } > >        public void removeObserver(Observer observer) { >                observers.remove(observer); >        } > >        public void notifyObservers() { >                for (Observer observer : observers) { >                        observer.update(); >                } >        } > >        public pointcut mutations(Observable observable) : execution(@Updates * > *.*(..)) && this(observable); > >        after(Observable observable) : mutations(observable) { >                for (Observer observer : observers) { >                        observer.update(); >                } >        } > > } > > -- > View this message in context: http://aspectj.2085585.n4.nabble.com/Advice-did-not-match-tp4643399.html > Sent from the AspectJ - users mailing list archive at Nabble.com. > _______________________________________________ > aspectj-users mailing list > aspectj-users@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/aspectj-users ]]> Fri, 18 May 2012 15:55:37 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13543.html andrew.clement@xxxxxxx (Andy Clement) Re: [aspectj-users] Aspect in an EAR file http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13542.html I don't see why you can't do this, but you will take a performance hit as it weaves at run time.

It is best if you can apply the aspects during compilation, but if that isn't an option then run time is your other option.

On May 18, 2012 6:10 AM, "jbolger" <john.bolger@xxxxxxxxx> wrote:
Hi,

Can you tell me if I can configure an aspect within an EAR to apply advice
against all code (including jars and wars) within the EAR and it's lib
(without having to define the aspect in each of the wars)?

Also in this case, which weaving style is most appropriate? Is it even
possible to perform compile/post-compile time weaving for an EAR when the
jars / wars it includes have already been built?

And finally, is any weaving style more performant than the other?

Thanks in advance,
John

--
View this message in context: http://aspectj.2085585.n4.nabble.com/Aspect-in-an-EAR-file-tp4644307.html
Sent from the AspectJ - users mailing list archive at Nabble.com.
_______________________________________________
aspectj-users mailing list
aspectj-users@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-users
]]> Fri, 18 May 2012 11:30:44 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13542.html planiturthian@xxxxxxx (James Black) [aspectj-users] Aspect in an EAR file http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13541.html Hi, Can you tell me if I can configure an aspect within an EAR to apply advice against all code (including jars and wars) within the EAR and it's lib (without having to define the aspect in each of the wars)? Also in this case, which weaving style is most ... Hi, Can you tell me if I can configure an aspect within an EAR to apply advice against all code (including jars and wars) within the EAR and it's lib (without having to define the aspect in each of the wars)? Also in this case, which weaving style is most appropriate? Is it even possible to perform compile/post-compile time weaving for an EAR when the jars / wars it includes have already been built? And finally, is any weaving style more performant than the other? Thanks in advance, John -- View this message in context: http://aspectj.2085585.n4.nabble.com/Aspect-in-an-EAR-file-tp4644307.html Sent from the AspectJ - users mailing list archive at Nabble.com. ]]> Fri, 18 May 2012 10:09:40 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13541.html john.bolger@xxxxxxx (jbolger) [aspectj-users] Advice did not match http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13540.html Can anyone tell me why I'm getting &quot;Advice did not match&quot; on the after advice in the following code, please? package edu.uat.cs2011.observerpattern; import java.util.ArrayList; import java.util.List; public aspect ObservableAspect { declare parents: hasmet... Can anyone tell me why I'm getting "Advice did not match" on the after advice in the following code, please? package edu.uat.cs2011.observerpattern; import java.util.ArrayList; import java.util.List; public aspect ObservableAspect { declare parents: hasmethod(@Updates * *.*(..)) implements Observable; private List<Observer> observers = new ArrayList<Observer>(); public void addObserver(Observer observer) { observers.add(observer); } public void removeObserver(Observer observer) { observers.remove(observer); } public void notifyObservers() { for (Observer observer : observers) { observer.update(); } } public pointcut mutations(Observable observable) : execution(@Updates * *.*(..)) && this(observable); after(Observable observable) : mutations(observable) { for (Observer observer : observers) { observer.update(); } } } -- View this message in context: http://aspectj.2085585.n4.nabble.com/Advice-did-not-match-tp4643399.html Sent from the AspectJ - users mailing list archive at Nabble.com. ]]> Thu, 17 May 2012 18:39:59 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13540.html hart404@xxxxxxx (hart404) Re: [aspectj-users] Corbetura + LTW http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13539.html Sorry I didn't reply sooner - at a conference right now. Yes, we can work with cobertura but you have to be careful on ordering when running it and AJ together. There is at least one open bug in this area: https://bugs.eclipse.org/bugs/show_bug.cgi?id=325362 cheers, Andy On 16 May 2012 08:09, Steve Ash <stevemash@xxxxxxxxx> wrote: > Just for anyone that runs across this in the googles-- this was just > me being stupid.  I had not cleaned the workspace and the class files > that corbetura was instrumenting were already woven at compile time. > So compile time ajc -> corbetura instrumentation -> LTW caused this > blow up.  You can see the ajc stuff already in the class file that I > attached to my previous message. > > Once I cleaned and re-ran letting javac build the original class files > then having corbetura instrument those and do LTW on the corbetura > classes  --- everything worked fine. > > So to answer my original question -- it appears that with corbetura > 2.5.1 and AspectJ Weaver 1.7.0.M1 -- LTW can weave into corbetura > instrumented classes. > > Steve > > On Tue, May 15, 2012 at 11:45 AM, Steve Ash <stevemash@xxxxxxxxx> wrote: >> I have run across a number of things on google so I know that this has >> come up in the past, but I couldn't get a clear answer.  So sorry for >> the re-post. >> >> I am trying to use corbetura + aspectJ LTW and the weaver is blowing >> up on the corbetura instrumented classes.  I am trying to dig in to >> the class file to see if I can spot the exact problem, but wanted to >> post and see if the expectation was that this would work or not.  I am >> using the 1.7.0.M1 weaver and this is the stack trace: >> >> SEVERE: com/argodata/empi/database/util/InsertIfMissingEntityLoader >> org.aspectj.apache.bcel.classfile.ClassFormatException: File: >> 'com.argodata.empi.database.util.InsertIfMissingEntityLoader': Invalid >> byte tag in constant pool: 0 >>        at org.aspectj.apache.bcel.classfile.ClassParser.readConstantPool(ClassParser.java:192) >>        at org.aspectj.apache.bcel.classfile.ClassParser.parse(ClassParser.java:131) >>        at org.aspectj.weaver.bcel.Utility.makeJavaClass(Utility.java:467) >>        at org.aspectj.weaver.bcel.BcelWeaver.processReweavableStateIfPresent(BcelWeaver.java:1387) >>        at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1097) >>        at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes(WeavingAdaptor.java:472) >>        at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass(WeavingAdaptor.java:323) >>        at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:99) >>        at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform(ClassPreProcessorAgentAdapter.java:54) >> >> I have a few spring-aspects @Transactional annotations in there >> weaving the before, after, and throwing advice for >> TransactionalAspect. >> >> I have attached the cobetura instrumented class file to this message >> if that helps at all. >> >> But I guess the main question is: should this work?  Or is this a >> known limitation? >> >> Thanks, >> >> Steve > _______________________________________________ > aspectj-users mailing list > aspectj-users@xxxxxxxxxxx > https://dev.eclipse.org/mailman/listinfo/aspectj-users ]]> Thu, 17 May 2012 17:45:13 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13539.html andrew.clement@xxxxxxx (Andy Clement) Re: [aspectj-users] Corbetura + LTW http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13538.html Just for anyone that runs across this in the googles-- this was just me being stupid. I had not cleaned the workspace and the class files that corbetura was instrumenting were already woven at compile time. So compile time ajc -> corbetura instrumentation -> LTW caused this blow up. You can see the ajc stuff already in the class file that I attached to my previous message. Once I cleaned and re-ran letting javac build the original class files then having corbetura instrument those and do LTW on the corbetura classes --- everything worked fine. So to answer my original question -- it appears that with corbetura 2.5.1 and AspectJ Weaver 1.7.0.M1 -- LTW can weave into corbetura instrumented classes. Steve On Tue, May 15, 2012 at 11:45 AM, Steve Ash <stevemash@xxxxxxxxx> wrote: > I have run across a number of things on google so I know that this has > come up in the past, but I couldn't get a clear answer.  So sorry for > the re-post. > > I am trying to use corbetura + aspectJ LTW and the weaver is blowing > up on the corbetura instrumented classes.  I am trying to dig in to > the class file to see if I can spot the exact problem, but wanted to > post and see if the expectation was that this would work or not.  I am > using the 1.7.0.M1 weaver and this is the stack trace: > > SEVERE: com/argodata/empi/database/util/InsertIfMissingEntityLoader > org.aspectj.apache.bcel.classfile.ClassFormatException: File: > 'com.argodata.empi.database.util.InsertIfMissingEntityLoader': Invalid > byte tag in constant pool: 0 >        at org.aspectj.apache.bcel.classfile.ClassParser.readConstantPool(ClassParser.java:192) >        at org.aspectj.apache.bcel.classfile.ClassParser.parse(ClassParser.java:131) >        at org.aspectj.weaver.bcel.Utility.makeJavaClass(Utility.java:467) >        at org.aspectj.weaver.bcel.BcelWeaver.processReweavableStateIfPresent(BcelWeaver.java:1387) >        at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1097) >        at org.aspectj.weaver.tools.WeavingAdaptor.getWovenBytes(WeavingAdaptor.java:472) >        at org.aspectj.weaver.tools.WeavingAdaptor.weaveClass(WeavingAdaptor.java:323) >        at org.aspectj.weaver.loadtime.Aj.preProcess(Aj.java:99) >        at org.aspectj.weaver.loadtime.ClassPreProcessorAgentAdapter.transform(ClassPreProcessorAgentAdapter.java:54) > > I have a few spring-aspects @Transactional annotations in there > weaving the before, after, and throwing advice for > TransactionalAspect. > > I have attached the cobetura instrumented class file to this message > if that helps at all. > > But I guess the main question is: should this work?  Or is this a > known limitation? > > Thanks, > > Steve ]]> Wed, 16 May 2012 15:09:36 GMT http://dev.eclipse.org/mhonarc/lists/aspectj-users/msg13538.html stevemash@xxxxxxx (Steve Ash)