Re: [aspectj-dev] AspectJ 1.8 and modularized JARs

["Edens, Eric" <ericeden@xxxxxxxxxx>]

​​Okay, I wrote the patch and it's getting reviewed internally. Should be ready to share soon.

I found an interesting feature in AspectJ where the output JAR has files removed from it. As a result of this, the module-info.class file and the multi-release class files are stripped from the resulting JAR.  [1]

​

I *think* this is okay, since anyone wanting to use these files shouldn't be using 1.8.​ Thoughts?

- Eric

1. https://github.com/eclipse/org.aspectj/blob/8c6b3ae13b105ce9bb9559de0ee4752cab5ba81c/org.aspectj.ajdt.core/src/org/aspectj/ajdt/internal/core/builder/AjBuildManager.java#L644-L652​

---

From: aspectj-dev-bounces@xxxxxxxxxxx <aspectj-dev-bounces@xxxxxxxxxxx> on behalf of Andy Clement <andrew.clement@xxxxxxxxx>
Sent: Friday, February 22, 2019 3:07 PM
To: AspectJ developer discussions
Subject: Re: [aspectj-dev] AspectJ 1.8 and modularized JARs

 

Hmmmmm, having jars around in a system that have module-info's probably suggests you should use Aspectj 1.9 - is there any reason not to update? 1.9 does everything 1.8 could do plus has more fixes and is compatible with later versions of Java, it doesn't force you to use Java9/11, it still supports source/target 1.8.

cheers,

Andy

On Fri, 22 Feb 2019 at 14:41, Edens, Eric <ericeden@xxxxxxxxxx> wrote:

When AspectJ 1.8 is used in Java 8 applications, we're seeing failures with modularized JARs. "File: 'module-info.class': Invalid byte tag in constant pool: 20". 

I see the module-info support was rolled forward into 1.9[1]. Any thoughts on having 1.8 ignore the new classes added by modularized and multi-release JARs?

- Eric

1. https://bugs.eclipse.org/bugs/show_bug.cgi?id=519976​

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/aspectj-dev