Re: [aspectj-dev] Compiling and not weaving

[Simone Gianni <simoneg@xxxxxxxxxx>]

Hi Andy,
thanks (as always) for taking the time to investigate.

Comments inline ...

Andy Clement wrote:
> It looks like that exception is due to a null delegate.  I have seen
> other reports of null delegate in the 1.6.1 release 
> that I have fixed (and some I haven't...).
>
> That error is coming out because you are using -outxml, you could turn
> that off temporarily to try and workaround 
> it but it is something that needs fixing, I will try and find a bit of
> time to recreate.  I doubt I have a single test that 
> exercises both -XterminateAfterCompilation and -outxml at the same time.
Yes, right, disabling -outxml fixes NPE. Unfortunately, since both
options are related to LTW, are likely to be used together by lazy
people like me :)

Do you want me to raise a bug for those NPEs?

>
> I think a testcase would be the best way to proceed.  I worry that you
> are having to try and 
> use -XterminateAfterCompilation because reweaving is not doing its job
> properly.  I'd rather
> fix reweaving than promote use of that -X option.
I do agree on that, in fact runtime exceptions are the blocking part,
and I'll try to keep an eye on them to raise bugs when they happen.

Given that reweaving works correctly under most situations, the benefit
I red about in some (rather old) mails and posts on the net about speed
and size reduction when using -XterminateAfterCompilation are now
minimal. Now that i can see it working, the time the build takes to
complete is exactly the same (around 10k java/aspectj lines, Maven), and
the size decrease is about 30% (may vary a lot, anyway are small numbers
in jars).

So the above bug would be really low priority.

Simone

-- 
Simone Gianni            CEO Semeru s.r.l.           Apache Committer
MALE human being programming a computer   http://www.simonegianni.it/