Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [aspectj-dev] access to AjNaiveASTFlattener buffer

The AST support has never been properly completed.  We deliberately
did the minimum necessary that people could at least start using it in
some form - with the hope that as the community started using it, they
would extend it, fill in the gaps and contribute the changes back to
the project.  See bugs like
https://bugs.eclipse.org/bugs/show_bug.cgi?id=110465 that cover work
that has been done this year on it.  If you want to fill in the blanks
and contribute it back, we are more than happy to accept the changes -
if they fit in with the general structure that we have started.

Andy.

On 14/12/06, Davi Pires <inhodpr@xxxxxxxxx> wrote:
Hi devs,

It appears to me that AjNaiveASTFlattener, in package
org.aspectj.org.eclipse.jdt.core.dom, is the only class
that, provided a CompilationUnit object, can generate code for that AST.

However, it does not support yet every node in the AST ( e.g.
DeclareParentsDeclaration). Therefore, if one needs to generate code for
these nodes, he/she could still resort to subclassing AjNaiveASTFlattener
and implement the necessary visit methods. The problem is that the
StringBuffer inside it has private access. Changing it to protected would
allow faster resolution of these problems, which, for me, have been truly
showstoppers.

What do you think of this simple change?

thanks,
Davi Pires

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev





Back to the top