Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [aspectj-dev] Writing an AspectJ test that copies resources?

Ok thanks Matthew. Hopefully this will be committed soon ;-)
 
I saw your bugzilla entry right after sending my email. I see the value of keeping the test harness simple although with load-time weaving, I can imagine wanting to test more carefully how non-source files get copied. Likewise, for testing the command-line weaving tool it would be helpful to have the ability to jar up and verify consistency of non-source/non-compiled files...
 

From: aspectj-dev-bounces@xxxxxxxxxxx [mailto:aspectj-dev-bounces@xxxxxxxxxxx] On Behalf Of Matthew Webster
Sent: Thursday, December 01, 2005 9:38 AM
To: AspectJ developer discussions
Subject: RE: [aspectj-dev] Writing an AspectJ test that copies resources?


Ron,

Already implemented, tested and submitted. The benefit of not having explicit copying is that the harness automatically renames files according the specification e.g. "aop-mystuff.xml" -> "META-INF/aop.xml". By and large simple the testcases used in the harness don't need to be parameterized with additional files.

Matthew Webster
AOSD Project
Java Technology Centre, MP146
IBM Hursley Park, Winchester,  SO21 2JN, England
Telephone: +44 196 2816139 (external) 246139 (internal)
Email: Matthew Webster/UK/IBM @ IBMGB, matthew_webster@xxxxxxxxxx

http://w3.hursley.ibm.com/~websterm/

Please respond to AspectJ developer discussions <aspectj-dev@xxxxxxxxxxx>

Sent by:        aspectj-dev-bounces@xxxxxxxxxxx

To:        "'AspectJ developer discussions'" <aspectj-dev@xxxxxxxxxxx>
cc:        
Subject:        RE: [aspectj-dev] Writing an AspectJ test that copies resources?


Hi Matthew,
 
I agree: your proposed design sounds right: the user’s Xlintfile should be able to just partially override the defaults. And thanks for adding the logic to copy Xlint.properties files. It seems like it would be useful to have a facility to copy non-compiled files in general in the harness, rather than adding special cases like aop.xml and Xlint.properties. Something like <copy file=”..”/> (somewhat reminiscent of ant).
 
Do you want to submit an updated patch for this logic or should I create one?
 




From: aspectj-dev-bounces@xxxxxxxxxxx [mailto:aspectj-dev-bounces@xxxxxxxxxxx] On Behalf Of Matthew Webster
Sent:
Thursday, December 01, 2005 7:18 AM
To:
AspectJ developer discussions
Subject:
Re: [aspectj-dev] Writing an AspectJ test that copies resources?

 

Ron,


There is no mechanism for resource copying and there is no test (that I can find) for "-Xlintfile" in aop.xml. In fact there are no explicit Xlint LTW tests. I will add the necessary logic to the harness to copy an Xlint.properties file because I have already done it for aop.xml. However I don't think the current implementation is correct nor do I think you patch completely fixes it. I believe it should work like this:

1. Load XlintDefault.properties (otherwise all lint messages are WARNING)

2. Overlay LTW defaults i.e. ignore "adviceDidNotMatch" (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=117854)
3. Overlay user "-Xlintfile" (so they only have to specify the messages they want to tailor)

4. Override with user "-Xlint" option


Matthew Webster
AOSD Project
Java Technology Centre, MP146
IBM Hursley Park, Winchester,  SO21 2JN, England
Telephone: +44 196 2816139 (external) 246139 (internal)
Email: Matthew Webster/UK/IBM @ IBMGB, matthew_webster@xxxxxxxxxx

http://w3.hursley.ibm.com/~websterm/

Please respond to AspectJ developer discussions <aspectj-dev@xxxxxxxxxxx>

Sent by:        aspectj-dev-bounces@xxxxxxxxxxx

To:        "'AspectJ developer discussions'" <aspectj-dev@xxxxxxxxxxx>
cc:        
Subject:        
[aspectj-dev] Writing an AspectJ test that copies resources?


I’m trying to write some regression tests for load-time weaving (for bug #118715)
 
To test this, I need to copy a resource file (an Xlint.properties file) over to the sandbox directory to be accessible from the classloader at runtime. Is there any means already defined for copying resources over to the sandbox?

 
Ron Bodkin

Chief Technology Officer

New Aspects of Software

w: (415) 824-4690

_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev
_______________________________________________
aspectj-dev mailing list
aspectj-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/aspectj-dev


Back to the top