RE: [aspectj-dev] project-specific settings

["Mik Kersten" <beatmik@xxxxxxx>]

Right, I'm in no way trying to downplay the need of the Ant support for
ensuring that builds run, or the need to run the Ant builds regularly.  But
note from my message below that setting the project's *source* compliance to
1.3 (in addition to setting the JRE lib) will ensure that non-compliant code
isn't added.

> -----Original Message-----
> From: aspectj-dev-bounces@xxxxxxxxxxx [mailto:aspectj-dev-
> bounces@xxxxxxxxxxx] On Behalf Of Wes Isberg
> Sent: October 6, 2005 10:33 AM
> To: AspectJ developer discussions
> Subject: RE: [aspectj-dev] project-specific settings
> 
> You're right that all the AspectJ modules/projects could be updated to
> require a JRE13_LIB variable and the Ant build will work, right now.
> But the JRE14_LIB variable does not prevent you from adding 1.4 code,
> which will cause Ant to gack, and without Ant support there's no
> guarantee that the source/lib used for Eclipse will actually work
> on the build machine, which I thought was the goal.  Like you, however,
> I don't like having to drop back to 1.3 for AspectJ when I'm
> developing other things in Java 5.
> 
> Wes
> 
> 
> > ------------Original Message------------
> > From: "Mik Kersten" <beatmik@xxxxxxx>
> > To: "'AspectJ developer discussions'" <aspectj-dev@xxxxxxxxxxx>
> > Date: Thu, Oct-6-2005 9:58 AM
> > Subject: RE: [aspectj-dev] project-specific settings
> >
> > Wes, I understand the issues that you raise, but I don't think that
> > they
> > will be triggered by this change.  Note that this change only has one
> > simple
> > effect, which is only noticeable by those developing in Eclipse, and is
> > totally unrelated to Ant builds.  Currently the compliance and JRE
> > settings
> > comes from the Eclipse workbench settings, which each developer is free
> > to
> > set differently.  This is why when developing AspectJ 5 (and hence
> > having
> > Eclipse default to a 1.5 JRE) it's easy to add 1.5 only calls as I had
> > accidentally done yesterday.
> >
> > All this change does is standardize source compliance and JRE settings
> > per-project in order to safeguard use of non compliant APIs and
> > constructs
> > (that the Ant build would eventually complain about, but that code
> > completion won't).  In my opinion every project that has developers
> > using
> > Eclipse should check in project-specific compliance settings.  But if
> > others
> > don't like this then I'm happy to keep them in my local workspace and
> > add
> > the .settings folder to .cvsignore.
> >
> > Mik
> >
> > > -----Original Message-----
> > > From: aspectj-dev-bounces@xxxxxxxxxxx [mailto:aspectj-dev-
> > > bounces@xxxxxxxxxxx] On Behalf Of Wes Isberg
> > > Sent: October 6, 2005 9:37 AM
> > > To: AspectJ developer discussions
> > > Subject: Re: [aspectj-dev] project-specific settings
> > >
> > > Right now, ajdoc can build with 1.3, like the other modules.  If you
> > add
> > > code
> > > requiring 1.4, it won't fail in Eclipse, but will in Ant when built
> > under
> > > 1.3
> > > (even though ajdoc should only be deployed with the tools.jar from
> > 1.4).
> > > So
> > > JRE14_LIB won't yet do what you suggest, though JRE13_LIB might.
> > >
> > > The current practice of building in Eclipse with a default 1.3 JRE
> > before
> > > checking in is documented in modules/build/readme-build-and-test-
> > > aspectj.html,
> > > so I'm not too worried about contributors.  I'm not interested in
> > > convincing
> > > contributors that they don't need to read the documentation, until we
> > > don't
> > > actually need the documentation :)
> > >
> > > Currently the Ant build system has variables for the minimum and
> > maximum
> > > VM,
> > > and builds under both.  That means we can change either in one line.
> > >
> > > Supporting the JREXX_LIB variables means keeping that in sync with
> > the -
> > > source
> > > option and the deployed VM's on a machine.  Right now the Ant build
> > > taskdef has
> > > to special-case Java 5 builds for that reason.
> > >
> > > So the current system works and can be updated with one line and one
> > > change by the Eclipse developer.  Supporting different JREXX_LIB
> > would
> > > require
> > > special-casing everything as we do the Java 5 support, and making
> > lots of
> > > changes
> > > for each VM upgrade.  Yuck!
> > >
> > > Changes to the build system should work both in Eclipse and on the
> > (Ant)
> > > build machine - work not just accidentally but as intended.
> > >
> > > Wes
> > >
> > > > ------------Original Message------------
> > > > From: "Mik Kersten" <beatmik@xxxxxxx>
> > > > To: "'AspectJ developer discussions'" <aspectj-dev@xxxxxxxxxxx>
> > > > Date: Thu, Oct-6-2005 8:44 AM
> > > > Subject: [aspectj-dev] project-specific settings
> > > >
> > > >
> > > > In order to make it easier to ensure that Java 5 source language
> > > > constructs
> > > > and libraries don't accidentally get used where they shouldn't, and
> > to
> > > > make
> > > > it easier for potential contributors to check out a compiling
> > AspectJ
> > > > source
> > > > tree, we could consider checking in the following project-specific
> > > > settings:
> > > > - Setting the source compliance (screenshot below).
> > > > - Configuring the classpath to use a JRE variable rather than the
> > > > default
> > > > container.
> > > >
> > > > To give this a try I committed project settings for ajdoc.  Note
> > that
> > > > this
> > > > means that you need a JRE14_LIB variable defined.  But I think that
> > the
> > > > need
> > > > to define such variables locally is obvious to most Eclipse
> > developers
> > > > and
> > > > won't require special instructions.
> > > >
> > > > Mik
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Mik Kersten, http://kerstens.org/mik
> > > >
> > > > _______________________________________________
> > > > aspectj-dev mailing list
> > > > aspectj-dev@xxxxxxxxxxx
> > > > https://dev.eclipse.org/mailman/listinfo/aspectj-dev
> > > >
> > > >
> > >
> > > _______________________________________________
> > > aspectj-dev mailing list
> > > aspectj-dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/aspectj-dev
> >
> > _______________________________________________
> > aspectj-dev mailing list
> > aspectj-dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/aspectj-dev
> >
> 
> _______________________________________________
> aspectj-dev mailing list
> aspectj-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/aspectj-dev