[aspectj-dev] Proposed changes to expose error/warning messages in ajde

["Adrian Colyer" <adrian_colyer@xxxxxxxxxx>]

In the course of tracking down the character encoding bug, I made the
following two (local) changes to the Ajde testsrc tree to expose
error/warning messages. All tests still pass (though you'll now see quite a
few warning messages that were previously suppressed). Since these changes
do not affect the built image, and improve our ability to diagnose and fix
ajde test failures, I propose we commit them as part of the run up to
1.1.0. I'll do that if there are no objections by tomorrow...

Cheers,
Adrian.


Index: BuildConfigurationTests.java
===================================================================
RCS file:
/home/technology/org.aspectj/modules/ajde/testsrc/org/aspectj/ajde/BuildConfigurationTests.java,v
retrieving revision 1.7
diff -u -r1.7 BuildConfigurationTests.java
--- BuildConfigurationTests.java    6 May 2003 12:48:04 -0000     1.7
+++ BuildConfigurationTests.java    9 May 2003 09:30:58 -0000
@@ -463,6 +463,7 @@
      }

      protected void setUp() throws Exception {
+           TaskListManager tlm = new NullIdeTaskListManager();
            preferencesAdapter = new UserPreferencesStore(false);
            buildOptions = new AjcBuildOptions(preferencesAdapter);
            compilerAdapter = new CompilerAdapter();
@@ -472,7 +473,7 @@
             String s = null;
             Ajde.init(
                 null,
-                null,
+                tlm,
                 null,
                 projectProperties,
                 buildOptions,
@@ -486,6 +487,7 @@
                 + LangUtil.renderException(t);
             assertTrue(s, false);
         }
+
      }

      protected void tearDown() throws Exception {
Index: NullIdeTaskListManager.java
===================================================================
RCS file:
/home/technology/org.aspectj/modules/ajde/testsrc/org/aspectj/ajde/NullIdeTaskListManager.java,v
retrieving revision 1.5
diff -u -r1.5 NullIdeTaskListManager.java
--- NullIdeTaskListManager.java     5 May 2003 15:18:01 -0000     1.5
+++ NullIdeTaskListManager.java     9 May 2003 09:30:58 -0000
@@ -43,6 +43,23 @@
         if (!hasWarning &&
IMessage.WARNING.isSameOrLessThan(message.getKind())) {
             hasWarning = true;
         }
+        StringBuffer sb = new StringBuffer();
+        sb.append(message.getKind().toString().toUpperCase());
+        sb.append(": ");
+        sb.append(message.getMessage());
+        ISourceLocation l = message.getISourceLocation();
+        if (l != null) {
+           try{
+                       sb.append(l.getSourceFile().getCanonicalPath());
+           }
+           catch(Exception e) {
+                       sb.append(l.getSourceFile());
+           }
+           sb.append(":");
+           sb.append(l.getLine());
+        }
+        System.err.println(sb.toString());
+
 //         System.out.println("> added sourceline task: " + message + ",
file: " + sourceLocation.getSourceFile().getAbsolutePath()
 //               + ": " +  sourceLocation.getLine());
     }

-- Adrian.
adrian_colyer@xxxxxxxxxx