Re: [aspectj-dev] Unexpected changes in AJDE interface (TaskListManager)

[Wes Isberg <wes@xxxxxxxxxxxxxx>]

My commit notes were probably too brief, and I apologize
again for a late API change.

This is needed to be able to decide whether to show/hide
the task list, for those that do so.  The default implementation
in the tree maintains a boolean for that, avoiding
the need to search.  I suppose this could be called
"couldHaveWarnings", with the correct response being always
true, to keep the message pane up.  (Needless to say, I don't
like the API either -- alteratives?)  In any case, since it's
ignored in AJDT, your implementation should be fine.

Wes

Andrew Clement wrote:
> 
> I just 'sunk' up with CVS this morning - I see a new method has appeared on
> the org.aspectj.ajde.TaskListManager interface called hasWarning() the
> description is:
> 
> 'return true if any messages in list have kind warning or greater'
> 
> I was just wondering if this method was in the right place?  AJDT
> implements this TaskListManager interface as a route for AspectJ to add
> sourcelinetasks to the eclipse task list.  If I extend that support to
> implement this new method then do I really have to provide an
> implementation that looks through the list of sourceline tasks I was
> previously passed from aspectj? In order to tell aspectj whether it
> previously added a warning or not?  It doesn't seem quite right - am I
> missing the idea behind this new method?  Right now, I just return false
> ...
> 
> cheers,
> Andy.
> 
> _______________________________________________
> aspectj-dev mailing list
> aspectj-dev@xxxxxxxxxxx
> http://dev.eclipse.org/mailman/listinfo/aspectj-dev