[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [albireo-dev] Re: AwtEnvironment & customizability

Bruno Haible wrote: 
Hi Gordon,

I wrote: 
I'll therefore try to move out to a separate class LookAndFeelHandler all
the policy, i.e. all the calls that should be customizable and deal with
look&feel.

Done now, through the appended patch.

This all looks reasonable. What happens if the l&f class has been explicitly set by the user through the system property, or though the Swing APIs? It would be better if we did not override the l&f in that case. But I'm not sure we can detect this in all cases...


One thing I'm not comfortable with is that the default L&F choice is
LAFChoiceNativeSystemForceGtk, which is exactly the same as you did.

The reason is that on the Linux system I happen to be using (openSUSE with KDE
desktop), the Gtk look&feel of Swing is not well supported: At the beginning
I get an error message in the console:
/opt/gnome/share/themes/Qt/gtk-2.0/gtkrc:5: Engine "qtengine" is unsupported, ignoring

I've seen this message before, and it depends on the window manager used, but there's nothing (reasonable) we can do to detect this situation.

BTW, if you haven't seen it, I found this article has some useful information on the evolution of the GTK l&f:

http://www.ffnn.nl/pages/articles/java/java-2-se-6.0-aesthetics-preview.php


In view of the bug that you found and reported
  https://bugs.eclipse.org/bugs/show_bug.cgi?id=126931
I think we must even make it
  LAFChoiceNativeSystemAvoidGtk
when running under JDK 1.6.


Yes, ideally, this should be the default under 1.6.