Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [aether-users] Making Aether work with Apache HttpComponents 4.3.x

Hi Benjamin,

>> Unfortunately, I am still encountering one test failure in
>> HttpTransporterTest.testConnectTimeout:
> 
> I updated the test.

thanks. Would it be possible for you to cut a 1.0.1 maintenance release
of Aether today that broadens the Import-Package declaration of
org.apache.http.* to [4.2.1,4.4)? This would allow Eclipse Code
Recommenders to ship on Wednesday with Aether 1.0.1, just in time for
the upcoming Mars M3 release and thus avoid Bug 450738 [1], which makes
Code Recommenders totally unusable in M3.

I have locally made the Import-Package change to Aether and tested Code
Recommenders on the Mars M3 Eclipse SDK and confirm that it works (at
least the functionality Code Recommenders exercises).

The necessary changes would be fairly minimal (beyond version-bumping):

In aether-core:
> diff --git a/aether-transport-http/pom.xml b/aether-transport-http/pom.xml
> index feb9adb..e86dcc7 100644
> --- a/aether-transport-http/pom.xml
> +++ b/aether-transport-http/pom.xml
> @@ -117,7 +117,7 @@
>          <artifactId>maven-bundle-plugin</artifactId>
>          <configuration>
>            <instructions>
> -            <Import-Package>org.apache.http.*;version="[4.2.1,4.3)",*</Import-Package>
> +            <Import-Package>org.apache.http.*;version="[4.2.1,4.4)",*</Import-Package>
>            </instructions>
>          </configuration>
>        </plugin>

In aether-update-site:
> diff --git a/core/src/main/tycho/pom.xml b/core/src/main/tycho/pom.xml
> index 35c12f7..278474c 100644
> --- a/core/src/main/tycho/pom.xml
> +++ b/core/src/main/tycho/pom.xml
> @@ -82,7 +82,7 @@
>      <repository>
>        <!-- convenient provider of OSGi-enabled httpclient for p2 to handle aether-transport-http -->
>        <id>orbit</id>
> -      <url>http://download.eclipse.org/tools/orbit/downloads/drops/S20131024145017/repository</url>
> +      <url>http://download.eclipse.org/tools/orbit/downloads/drops/R20140525021250/repository</url>
>        <layout>p2</layout>
>      </repository>
>    </repositories>

FYI, the Orbit S-build used is gone; you probably want to change that to
either a R(recommended)-build (guaranteed to be around forever) or a
"symbolic link" like
http://download.eclipse.org/modeling/emf/cdo/orbit/latest-I, which gives
you the latest I(ntegration)-build.

If there's anything I can do to assist in a 1.0.1 release a reality,
please tell me.

Best wishes,

Andreas

[1] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=450738>

-- 
Codetrails GmbH
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Phone: +49-6151-276-7092
Mobile: +49-170-811-3791
http://www.codetrails.com/

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940


Back to the top