Bug 4066 - Default extension in text search is often wrong (1GHFMPL)
Summary: Default extension in text search is often wrong (1GHFMPL)
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 23:05 EDT by Nick Edgar CLA
Modified: 2002-01-17 04:27 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2001-10-10 23:05:29 EDT
The Text search dialog fills in the extensions field with the extension of the active editor.
With the NLS work, I'm often looking at a .properties file, but want to search .java files.
I always have to override the default in this case.

It would be better if it simply remembered the last setting, rather than trying to match extensions.

NOTES:
DM (8/2/01 2:49:00 PM)
	The extension is also used to bring the right search page to front. 
	If I work on a Java file and press search I would expect the Java search page to be in
	brought to front. I assumed	this use case to be more often used than the one described above.
Comment 1 Martin Aeschlimann CLA 2001-10-16 11:13:55 EDT
moved to 'active'
Comment 2 DJ Houghton CLA 2001-10-29 17:29:59 EST
PRODUCT VERSION:
0.9

Comment 3 Erich Gamma CLA 2001-11-11 06:36:48 EST
so the proposal is to leave as is?
Comment 4 Dani Megert CLA 2001-12-04 07:04:38 EST
Yes. Proposal is to leave as is because all search stuff is input centric. We 
also try to set the fields (Search Expression, Search For, Limit To) from the 
current selection.

In my opinion the 80% case  is that if you select something and then press 
search, that you give it a context and that you expect the corresponding search 
page being in front and filled accordingly. Using previous values in the text 
search page would not fix the described problem since the wrong page is in front 
in the first place.

Suggest to close.
Comment 5 Nick Edgar CLA 2001-12-04 10:34:03 EST
Feels like to do better we'd need to know that entries in .properties files are 
often referenced by .java files.
Feel free to close if you don't think using previous settings is better.
Comment 6 Dani Megert CLA 2002-01-16 05:29:50 EST
Visited it again. Leave as is. Opening the text search for .properties makes sense.

What about a checkbox on the search page or a preference:
[x] Switch to page based on selection

Comment 7 Nick Edgar CLA 2002-01-16 21:13:19 EST
I'd prefer not to introduce another option.
I can live with the current behaviour.
Can close PR.
Comment 8 Dani Megert CLA 2002-01-17 04:27:49 EST
That's ok for me.