Bug 35380 - Replace with Local History and read-only resources
Summary: Replace with Local History and read-only resources
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0 M3   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-20 11:47 EST by Michael Valenta CLA
Modified: 2003-08-26 05:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2003-03-20 11:47:24 EST
Replace with Local History is disabled for read-only resources. I believe that 
it should be enabled and, if selected, should perform a validateEdit (Kevin, 
please comment if I am wrong about this).
Comment 1 Kevin McGuire CLA 2003-03-20 12:20:17 EST
Michael's comments are exactly correct.

I up'd the severity so this doesn't get lost.
Comment 2 Nick Edgar CLA 2003-03-21 11:51:42 EST
There are no interesting enablement criteria for these actions in 
org.eclipse.compare.  Should work.
Comment 3 Simon Arsenault CLA 2003-03-21 16:22:31 EST
If you look at the ReplaceWithPreviousEditionAction class (well actually its 
superclass EditionAction), when it handles a selection change callback, it 
calls getFiles(). This method ignores read-only files. So the list will be 
empty and the action enablement will be turned off.

Moving to compare component for comments.
Comment 4 Andre Weinand CLA 2003-03-28 09:36:01 EST
The validateEdit issues will be addressed after 2.1. 
Since the current behavior is "safe" (you cannot lose work),
I'm setting priority to P3 for now.
Comment 5 Andre Weinand CLA 2003-08-26 05:51:30 EDT
fixed for I20030826