Bug 32524 - CoolBar Clips 'run' icon
Summary: CoolBar Clips 'run' icon
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 2.1   Edit
Hardware: PC Linux-Motif
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-21 17:54 EST by Andrew Irvine CLA
Modified: 2004-04-26 16:45 EDT (History)
3 users (show)

See Also:


Attachments
Clipped icon (73.80 KB, image/png)
2003-02-21 17:55 EST, Andrew Irvine CLA
no flags Details
test case 1, jar file (5.49 KB, application/java-archive)
2003-02-26 16:38 EST, Lynne Kues CLA
no flags Details
test case 2, jar file (5.64 KB, application/java-archive)
2003-02-26 17:35 EST, Lynne Kues CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Irvine CLA 2003-02-21 17:54:32 EST
Eclipse 200302211557

The attached screenshot shows the 'run' icon being clipped on linux-gtk
Comment 1 Andrew Irvine CLA 2003-02-21 17:55:17 EST
Created attachment 3644 [details]
Clipped icon
Comment 2 Andrew Irvine CLA 2003-02-21 17:56:20 EST
The external tools icon was covered completely!
Comment 3 Lynne Kues CLA 2003-02-24 16:18:18 EST
Reassigning to SWT.

Do not see the behavior on Win2K or Motif.  Spent all day trying to install 
gtk2 (unsuccessfully).  Based on the attached screen snap, it appears that the 
GTK version of the coolbar is not honoring minimumSize.  I set the minimumSize 
of the coolitems to the maximumSize of the toolbar so that chevrons will never 
appear.  This behavior works on Motif and Windows, but not GTK for some reason.
Comment 4 Andrew Irvine CLA 2003-02-24 16:24:48 EST
The error does not appear everytime on GTK either.  I have seen extra space in 
the coolbars on windows/motif and gtk in the recent past, perhaps one weeks 
worth of builds.
Comment 5 Lynne Kues CLA 2003-02-24 16:40:11 EST
Note that "the extra space appearing" that AI mentions is another problem.  I 
will track that down.  This problem specifically has to do with chevrons 
appearing when they should not.  Andrew, under what circumstances did the 
coolitems get clippped?
Comment 6 Andrew Irvine CLA 2003-02-24 16:46:27 EST
I only saw the clipping when I first installed Eclipse 20030221.  My workspace 
was a previously created workspace, probably created by Eclipse 20030219.  I 
captured the screenshot, and then moved the coolbars around.  Since then I have 
not seen it again.
Comment 7 Veronika Irvine CLA 2003-02-25 10:29:28 EST
There was a fix to some size problems in toolbar on GTK for RC1.
The old workspace would have cached the wrong size information and tried to 
restore it.  Reseting the perspective or repositioning the hidden items should 
have fixed the problem.

I am going to close this bug report since it only occurs when moving between an 
~M5 workspace to an ~RC1 workspace.
Comment 8 Lynne Kues CLA 2003-02-26 16:38:03 EST
There are problems with coolitems getting clipped and the behavior does not have
to do with M4 workspaces.  I have one test case so far and am working on
another.  The behavior is leading to chevrons appearing in Eclipse when they
should not.  Note that I am on Linux-Motif.

For the first attached test case, run the example.  Notice that the first item
in the coolbar is completely clipped (slide the first gripper to the right to
see the coolitem that is being clipped).  Running the same example on Windows
correctly shows the first item.
Comment 9 Lynne Kues CLA 2003-02-26 16:38:44 EST
Created attachment 3733 [details]
test case 1, jar file
Comment 10 Lynne Kues CLA 2003-02-26 17:34:29 EST
1. Run the second attached test case.
2. Press the Add Tool Items button, which adds items to the third coolitem and
resets the preferred/minimumSize for the coolitem.

Notice that the third item is completely clippped.  The minimumSize is not being
honored.  Running the same test on Windows works.
Comment 11 Lynne Kues CLA 2003-02-26 17:35:09 EST
Created attachment 3737 [details]
test case 2, jar file
Comment 12 Veronika Irvine CLA 2003-02-28 12:22:50 EST
Nick has originally marked this as RC2 and then the bug was moved to the SWT 
shop.  SWT is looking at the problem but we are not committed to it for the 
RC2 milestone.
Comment 13 Felipe Heidrich CLA 2004-04-26 16:45:09 EDT
Fixed > 20040426 in HEAD
I tested both testcases and they are working fine.