Bug 23408 - Externalize JavaUISourceLocator.SourceLookupDialog
Summary: Externalize JavaUISourceLocator.SourceLookupDialog
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 2.0.2   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-11 09:53 EDT by Erin Harris CLA
Modified: 2002-09-17 14:36 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erin Harris CLA 2002-09-11 09:53:39 EDT
Externalize the SourceLookupDialog from the JavaUISourceLocator.  We would like 
to be able to bring up the same dialog if we fail to find a .jsp file or other 
file that we cannot search for using the JDT source locator.  Other JDT 
wrappering debug adapters might want to use this as well.
Comment 1 Darin Wright CLA 2002-09-16 15:23:32 EDT
Propose to add a constructor for the dialog as follows:

/**
 * Constructs a dialog to manipulate the source lookup path of the given
 * launch configuration. The source lookup path is retrieved from the given
 * launch configuration, based on the attributes
 * <code>IJavaLaunchConfigurationConstants.ATTR_DEFAULT_SOURCE_PATH</code> and
 * <code>IJavaLaunchConfigurationConstants.ATTR_SOURCE_PATH</code>. If the user
 * changes the source lookup path and presses "ok", the launch configuration
 * is updated with the new source lookup path. 
 * 
 * @param shell the shell to open the dialog on
 * @param message the message to display in the dialog
 * @param configuration the launch configuration from which the source lookup
 *  path is retrieved and (possibly) updated
 */
Comment 2 Darin Wright CLA 2002-09-16 15:33:48 EDT
Released to HEAD.
Comment 3 Darin Wright CLA 2002-09-17 12:31:35 EDT
Released to 2.0.2
Comment 4 Darin Wright CLA 2002-09-17 12:31:57 EDT
Please verify, Darin (S).
Comment 5 Darin Swanson CLA 2002-09-17 14:36:09 EDT
Verified.