Bug 22681 - [Wizards] 2.0.1: regression: Bug with rendering of wizard errors/warnings
Summary: [Wizards] 2.0.1: regression: Bug with rendering of wizard errors/warnings
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 major (vote)
Target Milestone: 2.0.1   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-22 04:55 EDT by Martin Aeschlimann CLA
Modified: 2005-05-10 14:54 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2002-08-22 04:55:24 EDT
2.0.1: 20020821

1. Open the new class wizard
2. enter a class name 'a'
   -> Rendered warning does not contain the warning icon, strangely alligned
3. Enter class name 'A+'
   -> Rendered error has no margin to the rigth border
Comment 1 Knut Radloff CLA 2002-08-22 21:56:21 EDT
Duplicate of bug 22681 ?
Comment 2 Knut Radloff CLA 2002-08-22 21:57:18 EDT
Of course not, I meant bug 22607 !
Comment 3 Martin Aeschlimann CLA 2002-08-23 03:41:44 EDT
Doesn't sound like a duplicate. (this worked before)
The error icon is shown, but the margin is wrong.
The warning icon is gone, margin now very big.
Comment 4 Tod Creasey CLA 2002-08-23 11:15:48 EDT
Fixed in build >20020823
Comment 5 Martin Aeschlimann CLA 2002-09-02 12:33:59 EDT
Not fixed, border is still too small for errors and warnings.
(or is this a bug fix?)

see attachment
Comment 6 Martin Aeschlimann CLA 2002-09-02 12:36:47 EDT
attachment 1920 [details]
Comment 7 Martin Aeschlimann CLA 2002-09-02 13:08:58 EDT
also note the different font used for the header
Comment 8 Tod Creasey CLA 2002-09-03 08:37:31 EDT
In 2.0.1 the spacing was made consistent with the rest of the dialog (we use 
convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_SPACING) to 
determine it.

This was done in order to maximize the real estate for the error messages 
(there have been many cases of them being too long)and to keep the layout 
consistent with the rest of the dialog.
Comment 9 Martin Aeschlimann CLA 2002-09-03 08:55:28 EDT
I doesn't look consistent at all, the error icon has the smallest margin of all 
labels. Have a look at the title or description margin.
Comment 10 Tod Creasey CLA 2002-09-03 09:11:34 EDT
In 2.0 we used hardcoded values for these indents:

// Space between the top of the title area and the title
private static final int H_INDENT_TITLE = 7;
// Space between the left of the title area and the title
private static final int V_INDENT_TITLE = 8;
// Space between an image and a label
private static final int H_GAP_IMAGE = 5;
// Space between the title bottom and message area top
private static final int V_INDENT_MSG_AREA = 3;
// Space between the left of the title area and the message
private static final int H_INDENT_MSG = 11;
// Space between the message area top and the top of the message label
private static final int V_INDENT_MSG = 3;

In 2.0.1 we based these values on the dialog font. We could just return them 
back to the old values but it would be better if we based them off of the size 
of the icon - this would not work with icons that are a different size than 
the ones we currently use.
Comment 11 Tod Creasey CLA 2002-09-03 09:22:33 EDT
Looking at the code again the case you are concerned with is due to an 
accessibility requirement in order that Eclipse pass section 508.

JAWS has a limitation that it can only read images that are the direct 
children of the shell. In order to pass this we had to avoid putting any 
widget we show in a composite - this resulted in us not being able to space 
around the icon as we would have ended up with lines in the shell colour.

We have two options here
1) Put the icon in a Composite with labels to space it out. This will likely 
mean that JAWS will not read the icon.
2) Try and put a canvas behind it for spacing
3) Add in extra spacer labels for the blank space.
Comment 12 Tod Creasey CLA 2002-09-03 10:49:44 EDT
Added in a new spacer label on the left that is the same size as the old 
H_GAP_IMAGE. Released in both streams.
Comment 13 Tod Creasey CLA 2005-05-10 14:54:11 EDT
Marking as closed.