Bug 22191 - When adding a new feature with the Update Manager the user gets to select the location where the update is installed
Summary: When adding a new feature with the Update Manager the user gets to select the...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 blocker (vote)
Target Milestone: 2.0.1   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-05 20:33 EDT by Tim Koss CLA
Modified: 2002-08-23 13:56 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Koss CLA 2002-08-05 20:33:24 EDT
When the user is using the Update Manager to add a new feature to their product,
after they accept the user license they then get offered a page where they can
select where to put the feature. The list includes the product location as well
as the extension(s). In the case of our product, we ALWAYS want our features to
be put with our extension. We have used the collaction-affinity tag to enforce
this. The problem is that even though the feature has used the tag to say where
it wants to beinstalled, the user can change this. To make matters worse, the UI
that offers them where to put the feature is very confusing and can very easily
be used improperly.

If a feature has a collocation-affinity tag, the user should not see this
Install Location page
Comment 1 Dejan Glozic CLA 2002-08-06 20:46:39 EDT
There are two defect reports in one here.

1) When collocation-affinity is defined and the referenced feature can be 
found, do not offer the target page

2) Target location page is confising because ....

It would help if these two defects are separated i.e. this one is kept for 
issue 1) while another is opened for 2).
Comment 2 Dejan Glozic CLA 2002-08-07 17:32:52 EDT
Another issue is that installation may fail because:

1) The location where the co-located feature is installed is read-only
2) The location where the co-located feature is installed is full (there is not 
enough space to install the new feature)

In this case, the user will not be able to do anything until 1) or 2) is 
addressed. Do you think it is OK?
Comment 3 Tim Koss CLA 2002-08-08 11:04:42 EDT
If the user cannot access the collocation-affinity location or it is full, then
letting them randomly download the features to some other location does the user
no good - they still can't activate the features, and they cannot get the
non-eclipse data that comes with our drop. In the event of an error, the user
should be notified about the error and then the download shoud fail. It is now
up to the user to rectify their problem
Comment 4 Dejan Glozic CLA 2002-08-08 19:04:01 EDT
OK, so the proposed fix should be:

IFF (if and only if :-) the feature has the colocation-affinity attribute
set and the referenced feature can be found, we will prevent users from 
installing elsewhere.

We need to choose how to do the prevention: we can either hide the page or hide 
other sites and disable 'Add' button.

I vote for filtering/disabling because the page can still show useful 
information (target site, required size, available size).
Comment 5 Tim Koss CLA 2002-08-08 19:13:06 EDT
If you do the prevention, you also need to ensure that the user cannot select
from the available list either, since they could still put it in the wrong
place, unless you only had the location that was the collocation-affinity
Comment 6 Dejan Glozic CLA 2002-08-08 20:35:31 EDT
The prevention is two-prong:

1) It filters all the sites from the list except the affinity site
2) It disables 'New' so the user cannot define a completely new location and 
install there

The remaining (affinity) site will be selected and the user will have the 
benefit of seeing where the feature will go as well as if there is enough space 
on the device.
Comment 7 Dejan Glozic CLA 2002-08-08 20:36:56 EDT
Fixed in 2.0.1 stream.
Comment 8 Brooke Kuhlmann CLA 2002-08-23 13:56:38 EDT
Verified.  This is fixed.  Correct behavior of a disabled "Add" button is happening.  Also, the 
affinity site is only listed in the box while the other sites are removed.