Bug 22064 - Install Handlers not run with -initialize flag
Summary: Install Handlers not run with -initialize flag
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P1 blocker (vote)
Target Milestone: 2.0.1   Edit
Assignee: Christophe Elek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-30 17:52 EDT by Tim Koss CLA
Modified: 2002-08-23 17:02 EDT (History)
1 user (show)

See Also:


Attachments
Custom Install Handler Test File (9.39 KB, application/zip)
2002-07-30 20:51 EDT, Brooke Kuhlmann CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Koss CLA 2002-07-30 17:52:43 EDT
With our native installer, we are laying down our base features. These features
also have install handlers to complete their work. According to the update team,
on the first time we run, if we use the -initialize switch, the install handlers
should all be run with the completeConfigure method be called. This is not
happenning. When we run with -initialize, our features install handlers are not
being run
Comment 1 Christophe Elek CLA 2002-07-30 18:33:55 EDT
Sorry if we misled you.
We probably meant the first time eclipse runs (when no workspace exists before)
Comment 2 Brooke Kuhlmann CLA 2002-07-30 20:51:12 EDT
Created attachment 1774 [details]
Custom Install Handler Test File
Comment 3 Brooke Kuhlmann CLA 2002-07-30 20:52:24 EDT
STEPS TO RECREATE:

Use attachment (com.ibm.ive.test_1.0.0.jar)

This is what happens 
when you try the -initialize option:

1.  Unzip the com.ibm.ive.test_1.0.0.jar to a 
com.ibm.ive.test_1.0.0 folder inside the eclipse\features folder of a fresh eclipse 2.0 
base.
2.  Run eclipse.exe -initialize.  A workspace will be created.
3.  Notice that there is NOT 
a com.ibm.ive.personalconfig-install.log in the root of the eclipse\features folder.  This 
shows that the -initialize option did not call the custom install handler of the test 
feature.

This how you can manually force eclipse to install a custom install handler feature 
(as an alternative to performing a update via the Update Manager);

1.  Unzip the 
com.ibm.ive.test_1.0.0.jar to a com.ibm.ive.test_1.0.0 folder
2.  Launch a fresh copy of 
Eclipse 2.0 (i.e. no workspace has been created yet).
3.  Shut down eclipse
4.  Place the 
com.ibm.ive.test_1.0.0 folder inside the eclipse\features folder.
5.  Launch eclipse
6.  
Notice that you will have a dialog asking for you to accept pending changes.  Choose to accept.
7.  
Let eclipse restart.
8.  Notice that there is a com.ibm.ive.personalconfig-install.log in the 
root of the eclipse\features folder.  This means that the custom install handler code was run.
Comment 4 Christophe Elek CLA 2002-07-31 00:37:26 EDT
Checked 2.0 code. We do not call the install handler during a reconciliation
where the new feature is found and enabled (optimistic).
the code is changed in 2.0.1 (will check with 2.0.1)

the new code will call the install handler if a new feature is found and the
reconciliationis optimistic.
The new code does not call the install handler during an enable/disable of an
already existing feature.
Comment 5 Vlad Klicnik CLA 2002-07-31 08:59:16 EDT
need to address for 2.0.1
Comment 6 Christophe Elek CLA 2002-07-31 10:18:23 EDT
Was already fixed in 2.0.1. Verified based on brooke comments:

"I downloaded the 2.0.1 integration build of eclipse off www.eclipse.org.
The exact file was:  eclipse-SDK-20020724-win32.zip.

When I put my custom install handler feature in the features folder and
ran eclipse -initalize, I noticed the feature was properly installed and
the custom install handler was initialized.

So I can see that 2.0.1 solves our problem but in 2.0.0 this does not
work.

-Brooke-
"
Comment 7 Vlad Klicnik CLA 2002-08-01 09:36:28 EDT
Tim, can you guys also verify that fix for bug 20686 (which as a side-effect 
fixed this problem) gives you expected behavior for Revert operations?  I would 
expect (am guessing here) your customers are likely to save different 
configurations representing the various target environments, and then use revert 
to switch back-and-forth. So want to make sure you verify this is working as 
expected (we have tested this but there is nothing like real usage test).
Comment 8 Christophe Elek CLA 2002-08-22 09:50:20 EDT
Please let us know if we can close it for 2.0.1
Comment 9 Brooke Kuhlmann CLA 2002-08-22 21:28:44 EDT
Based of the latest WSWB drop of I20020821, I have verified that the troubles with the -initialize 
option have now gone away.  As for the revert command, this looks good as well.  I can revert to past 
configurations and then forward again and do not notice any errors or corruption in the 
workspace.  If I should be looking at something more specific, let me know.
Comment 10 Dejan Glozic CLA 2002-08-23 17:02:47 EDT
Confirmed as fixed.