Bug 21041 - [Update] Force welcome page first time a new feature is installed
Summary: [Update] Force welcome page first time a new feature is installed
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P1 blocker (vote)
Target Milestone: 2.0.1   Edit
Assignee: Randy Giffen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-26 21:48 EDT by Peter Manahan CLA
Modified: 2002-08-23 14:26 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Manahan CLA 2002-06-26 21:48:18 EDT
When a new feature is installed if it has a welcome.xml there is no way to 
force it to show up the first time the eclipse is launched after installing 
the feature. Now that the user has this new handy dandy function products 
would like the user to be able to see the welcome page without having to go to 
the welcome dialog.

This is of course in the case of the addition of a feature with a older 
workspace not a fresh workspace.
Comment 1 Greg Adams CLA 2002-07-08 12:03:38 EDT
After installing an extension , it’s welcome page should be presented to the 
user. The primary purpose of the main welcome page is to introduce someone into 
the product. Once new functionality is installed through an extension the 
extension’s welcome should be presented in order to introduce the new 
functionality.
This is critical for us so we have up'd the priority accordingly. Without this 
ability a user may fail to find new functionality.
Comment 2 Pat McCarthy CLA 2002-07-08 15:34:38 EDT
By forcing the welcome page are we also saying this should be done in using the 
perspective that could be associated to the welcome in the associated branding 
plug-in about.ini config?

Will also need to consider the use case when multiple extensions are added at 
the same time.  What is the pecking order?  Do we just open one or all?
Comment 3 Nick Edgar CLA 2002-07-08 15:50:50 EDT
Could have a special welcome page for feature updates with a generic 
description, and pointing to Help / Welcome... if there are new welcome pages.
Could also embed links to the new pages directly in this page.
Comment 4 Peter Manahan CLA 2002-07-08 15:52:46 EDT
Welcome should use the perspective last left open. If the new extension 
provides a new perspective which it would like to display the welcome page 
should open in that perspective.

In the case of multiple extensions: 
1) last man in wins the race in terms of perspective viewed. 
2) For welcome pages you should be able to show them all.
Comment 5 Greg Adams CLA 2002-07-08 17:46:51 EDT
* I concur with Peter.

* An additional idea (although I don't know if I like this & you should ask 
julian) is that if multiple extensions come along and hence multiple welcomes 
would appear, the platform could should a welcome page listing the newly 
installed extensions and show allow you to click on them to get their welcome.  
There are no doubt a number of possible other ideas that I am sure will come up 
as you look to implement this one.

With respect to nick's comments
1) We do not want another special mechanism. There is already a welcome 
mechanism defined for this (see peter's note)

2) This is not just an update issue (i.e. features updated from the web etc). 
It also relates to the wsad -> wsadie upgrade case. At the end of upgrading to 
wsadie we should be able to make it look like that's what you started with.

3) Even in the case where we are adding onto some other product (again without 
actually deploying through update, but instead through an install) we also want 
to be able to have our welcome show up.
Comment 6 Nick Edgar CLA 2002-07-09 15:52:13 EDT
Needed for 2.0.1.
Comment 7 Randy Giffen CLA 2002-07-24 12:21:18 EDT
We can automatically open the welcome page for a new feature on restart. As 
mentioned, if multiple new features are present we could open the welcome page 
for each of them with the final one getting to choose the perspective.

In practice it seems not many features are specifying a particular perspective 
for their welcome page.

This behavoir is differerent than startup where we only show the welcome page 
for the primary feature. The first link on the platform welcome page opens the 
Help>Welcome dialog showing the list of installed features which supplied 
welcome pages.
Comment 8 Nick Edgar CLA 2002-07-24 14:55:36 EDT
How would we determine which new features there were?
Require new API from update-core for this.
Comment 9 Randy Giffen CLA 2002-07-24 15:04:45 EDT
Vlad recommends we keep the list of features/versions as state, and compare on 
each startup. 
Comment 10 Randy Giffen CLA 2002-07-30 15:31:05 EDT
Released changes to 2.0.1 and 2.1 
Comment 11 Nick Edgar CLA 2002-08-07 11:47:00 EDT
Running the 20020806 build on an old workspace, I got all 3 welcome pages when 
it came up.
Should avoid opening the welcome pages if the old list of features was not 
remembered.
Comment 12 Randy Giffen CLA 2002-08-07 12:16:31 EDT
Fixed to ensure welcome pages are not shown unless we have the old list of 
features.
Comment 13 Knut Radloff CLA 2002-08-22 19:29:56 EDT
2.0.1 build 20020821

Not sure if this is working correctly. I have a fresh install, new workspace. 
When I start I get one welcome page "Eclipse Platform". I close it and restart 
and it stays closed.
Now I go to a local update site and 
-install the P3ML feature from WSDD 5.0 build 23415 (which, I'm pretty sure, 
doesn't have a welcome page)
-restart and now have three welcome pages for Eclipse PDE, Eclipse JDT and 
Eclipse Platform (again). 

That doesn't seem right. Should I have gotten all three welcome pages when I 
ran the 2.0.1 build for the first time on a fresh workspace?

Someone please give the URL for an update site that has features with a welcome 
page. I'd like to test this more.
Comment 14 Randy Giffen CLA 2002-08-23 09:30:18 EDT
It works as expected for me at:
http://dev.eclipse.org/viewcvs/index.cgi/%7Echeckout%7E/platform-update-
home/site/ 

Try installing a version of alphbet soup
On restart the welcome pages (and only those pages) for the new features 
appeared.

What is the url for the update site you had the problem with so I can try to 
recreate.
Comment 15 Randy Giffen CLA 2002-08-23 09:40:20 EDT
Knut could you attach your update log
Help>About>Configuration Details> the *** Update Manager Log: section
Comment 16 Knut Radloff CLA 2002-08-23 11:21:20 EDT
The update site is on a ral6f drive. I don't think you can access it. If you 
can find a WSDD 5.0 build in OTT you should be able to try this out.

Here's the update log:
*** Update Manager Log:

Configuration=Aug 22, 2002 7:33:09 PM
Current configuration=false

Date=Thu Aug 22 19:33:09 EDT 2002
Target=file:D:/Images/Eclipse/dev/eclipse/
Action=Site installed
Status=Success

Date=Thu Aug 22 19:33:10 EDT 2002
Target=file:D:/Images/Eclipse-
Workspaces/inner/.metadata/.config/platform.cfg.metadata/LocalSite.xml
Action=Reconcile
Status=Success

----------------------------------------------------
Configuration=Aug 22, 2002 7:33:50 PM
Current configuration=true

Date=Thu Aug 22 19:33:56 EDT 2002
Target=com.ibm.ive.mlrf.p3ml_4.99.20020816.5
Action=Feature installed
Status=Success

Date=Thu Aug 22 19:34:16 EDT 2002
Target=com.ibm.ive.mlrf.p3ml_4.99.20020816.5
Action=Enabled
Status=Success
Comment 17 Knut Radloff CLA 2002-08-23 11:35:18 EDT
I still see the problem of JDT, PDE and Platform welcome pages showing up when 
I install the first new feature.
Steps to reproduce:
 -take a fresh 2.0.1 build (20020821)
 -start with a new workspace
 -close the Platform welcome page
 -restart Eclipse
 -install the Alphabet Soup feature (I used version 2.0.0)
 -when prompted to restart select yes
 -I now have six welcome pages, three for alphabet soup features and three for 
Eclipse JDT/PDE/Platform
 
Comment 18 Knut Radloff CLA 2002-08-23 11:51:13 EDT
It works fine (no extra welcome pages) when I don't start Eclipse with the -dev 
bin argument.
Comment 19 Randy Giffen CLA 2002-08-23 12:20:54 EDT
Yes that will do it.
The -dev bin command line option causes the update component to report no 
features (you can verify this in the about dialog). See bug 18820
Interestingly, after you perform the update the features are reported.

Comment 20 Knut Radloff CLA 2002-08-23 14:26:45 EDT
Specifying -update in addition to -dev bin as suggested in bug 21638 works as 
well.
Annotated bug 18820. Marking this one as verified since welcome pages are 
displayed properly when not in dev mode.