Bug 20866 - Feature without license cannot be disabled.
Summary: Feature without license cannot be disabled.
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P1 blocker (vote)
Target Milestone: 2.0.1   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-23 20:39 EDT by Peter Manahan CLA
Modified: 2002-08-02 17:33 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Manahan CLA 2002-06-23 20:39:20 EDT 
eclipse integration build 20020621. Window XP.
java version "1.3.1_02"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.1_02-b02)
Java HotSpot(TM) Client VM (build 1.3.1_02-b02, mixed mode)

Create a feature without a license. Lay it down manually with a fresh eclipse 
install. The feature will be added to the config and be available but the 
features without licenses cannot be disabled.

This is an example feature.xml

<?xml version="1.0" encoding="UTF-8"?>
<feature
      id="bug.feature.lic"
      label="Feature for an Update URL only"
      version="1.0.0"
      provider-name="IBM">

   <url>
	   <update label="Update Site" url="http://www.ibm.com"/>
   </url>

</feature>
Comment 1 Greg Adams CLA 2002-07-08 12:13:20 EDT 
The current rule seems to be that  features with no license cannot be updated. 
However it still gets loaded. When this occurs it can not be updated or 
disabled via eclipse. It needs to be removed manually. Because
the features some products ship may ship without licenses (the license is 
accepted at install time) This means that the product would not be updateable. 
What should occur is that the feature being "downloaded" from the update site 
have a license for click through.

We have up'd the severity of this.
Comment 2 Pat McCarthy CLA 2002-07-08 15:28:24 EDT 
To be clear, only root features can be disabled.  So the license would only have 
to be in the root feature.

That said, it is confusing to be blocked by license text that is only visible 
during the act of an update (the accept/reject question).  The update manager 
only seems to be able to show license content from the identified html reference 
and not the text in feature.properties (unless in the update wizard).
Comment 3 Greg Adams CLA 2002-07-08 17:54:58 EDT 
The point is the presence/absence of license cannot be a blocking factor.
Comment 4 Dejan Glozic CLA 2002-07-10 16:29:40 EDT 
Should not prevent Enable/Disable if a feature without a license has already 
been installed.
Comment 5 Dejan Glozic CLA 2002-08-01 20:34:37 EDT 
The problem in code is that absence of license causes the 'do' button to be 
hidden irrespective to the feature context. The correct fix would be to test 
the license presence only for features that are not in the local site context 
(i.e. already present in the current configuration).
Comment 6 Dejan Glozic CLA 2002-08-02 17:33:32 EDT 
Fixed in 2.0.1 stream