Bug 20248 - [Compare] Have to perform two actions to see diff
Summary: [Compare] Have to perform two actions to see diff
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.0   Edit
Hardware: Other other
: P3 enhancement (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-13 14:02 EDT by Scott Rutledge CLA
Modified: 2003-03-31 23:27 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Rutledge CLA 2002-06-13 14:02:02 EDT
As of F3, when you perform Compare With->*, you are presented with a diff view, but no diff is shown. 
In order to actually see the diff, you have to double-click the node in the tree-portion of the 
view.

I understand this was done to avoid server chatter in the sync view, but in this case 
having to double-click is redundant (I've already said I want to see the diff).
Comment 1 Erich Gamma CLA 2002-06-15 04:59:33 EDT

*** This bug has been marked as a duplicate of 20106 ***
Comment 2 Scott Rutledge CLA 2002-08-06 10:48:08 EDT
Although the bug this one has been marked as a duplicate of has been fixed, this problem still 
occurs: the user is forced to double-click the item in Diff view in order to actually see the diff.
Comment 3 Scott Rutledge CLA 2002-08-22 22:30:16 EDT
Reopening. Please bring up the diff for the first file automatically.
Comment 4 Johan Compagner CLA 2002-09-26 10:29:40 EDT
Do not always bring it up
If i am working remote from a cvs server and i do a synchronize i don't want 
to wait forever when i select a file in the sync view.

The synch view first did this (directly compare the selected file) and there 
where complains about that (which i agree with)

The problem is that when you select a file and do compare->with then it should 
be smart enough to directly open it.
Comment 5 Brian Cort CLA 2002-09-26 11:04:05 EDT
The issue for me isn't whether it takes one action or two from the synchronize
view. I didn't even know that it was possible to diff the repo's copy with mine.
How was I to know that double-clicking would do this (and not update or commit
or something dangerous!)?

There should be a pop-up (right-click) menu entry for diff'ing. E.g. 'Compare to
local copy'.

I agree Johan that selecting a file and choosing 'compare with' should always
bring up the diff pane right away.

Finally, in the Synchronize view, selecting another entry in the top pane should
either clear or update the diff pane. These shouldn't be allowed to be inconsistent.
Comment 6 Bob Foster CLA 2002-09-26 15:34:01 EDT
Agree with Brian, this stuff is shrouded in mystery.

I still don't know how to resolve conflicts in Eclipse. In some files, the
"differences merged" (the bottom) menu item would never enable, no matter what I
did to the file.

I didn't dare try to commit. The last thing I want is to throw away my changes
and go back to the repository view.

The work cycle I am used to on the command line is: 1) Make changes, 2) Update,
3) Resolve conflicts, 4) Commit. How do you accomplish this in Eclipse?
Comment 7 Bob Foster CLA 2002-09-26 15:55:01 EDT
The above questions are meant to be illustrative, not trying to turn this into a
newsgroup. ;-}
Comment 8 Erich Gamma CLA 2002-09-28 04:59:37 EDT
There should be a context menu entry that corresponds to the double click action
that shows the diff. This action should be provide in both the compare with and
synchronize operations. The compare operation is contributed by compare and the
synchronize one is contributed by VCM.

Andre can you please take care of the compare operation and then move the bug on
the VCM
Comment 9 Andre Weinand CLA 2003-02-18 19:31:52 EST
fixed and released for I20030220
Comment 10 Scott Rutledge CLA 2003-03-31 23:27:56 EST
As of 2.1, performing Compare With->Latest From HEAD on a single file still does
not show the diff automatically, it still requires a second action (selecting
the file, which is already selected in the view).