Community
Participate
Working Groups
Build 20020611 I got in a situation today where I had single-click behaviour in the Navigator and Packages view even though I did not change the preference. The chief suspect is the call to OpenStrategy.setOpenMethod in CompareEditorInput. I do not have a repeatable case, but Dejan tells me he saw it today as well, and he was also using Compare extensively. Even if this problem did not occur, it seems dubious to override the user's preference.
Steps to reproduce this: - open Sync view as a fast view - do a sync to release some changes - release them, clearing the sync view's panes - click on a part which does not take focus to dismiss the sync view, such as an Outline view when there are no open editors, or an empty editor area Workaround: - Workbench / Preferences / Workbench - select Open mode / Single Click - Apply - select Open mode / Double Click - OK
This is a workaround to avoid that right clicking to pop-up a menu triggers the compare. This is critical since when you have a large zip that you just want to commit there was no way to do so without triggering the diff. The OpenStrategy handles this case in single click mode. The open strategy is set on focus and reset when the focus is lost, so this means that a focus lost event must have been missed. We should investigate when this can happen. If this cannot be tracked down then there are two options: - rollback the old behaviour, then the zip problem will show up again - have the compare view honor the open strategy, which would require users to double click to trigger a diff when single click mode isn't set. We will not be able to address this for F3
Please bump up priority as I consider this a stop ship. Another option is for us to provide API which will allow you to use single click mode without changing the global strategy.
Here is a reproducable test case: - load a project from a repository - do some change to a file - select that file - synchronize the file with repository - make sync view a fast view - synchronize the file again with repository observe: the synchronize view pops up and is activated (added code to trace activation and deactivation in CompareEditorInput). - now select the file you synchronized observe: you receive a second activate event which reads the changed open strategy mode. As a result single click gets restored on a deactivate.
The problem is that we end up having more than one listener changing the open mode which makes is hard to guaruntee that in all cases we restore the value of the open mode to its original value. The fix is that we fully honor the open mode strategy in compare and don't change the mode behinde the scenes. Additionally we add an Open action to the context menu. This make compare consistent with the rest of the platform.
Discussed fix with Erich and we agree to fix it this way
Removed code that manipulates the OpenStrategy. Added code that structure compare pane (the one on the right hand side) works on single click. This is no problem since the file is loaded from the repository already.
It is not possible to add an open action since the viewer in the left pane is unknown for comapre. It is provided by team. If we want an open action, team must provide one.
Fixed as proposed for build input 20020612a. Fixed reviewed by Adam Kiezun
Verified. TB