Bug 18318 - Empty folders created when ugrading Eclipse
Summary: Empty folders created when ugrading Eclipse
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: 2.0.1   Edit
Assignee: Christophe Elek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-05-30 10:36 EDT by Rodrigo Peretti CLA
Modified: 2002-08-22 09:48 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Peretti CLA 2002-05-30 10:36:23 EDT
build 20020530

I usually install Eclipse in a folder named after the build number (e.g. 
c:\eclipse\20020529\eclipse...). When I install a new version of Eclipse, I 
usually move that folder to somewhere else (e.g. c:\eclipse\old\20020529
\eclipse...) in order to prevent it from getting any information from the old 
build. What I've notice is that when I upgrade from 0529 to 0530, the old 
location is created as am empty folder and not only the old location. Today, 
when installing Eclipse, I've got 3 empty folders created (20020527, 20020528 
and 20020529). It is not critical but gives a really bad impression about the 
product quality.
Comment 1 Vlad Klicnik CLA 2002-05-30 11:27:36 EDT
Sorry Rodrigo, I don't follow the steps. What exactly are you doing? Unziping 
builds and renaming/ moving directories? Are you using the update manager to 
update (if so, what steps you used)? Something else?
Comment 2 Rodrigo Peretti CLA 2002-05-30 11:33:40 EDT
Sorry for not being clear. I'm just unzipping drops and not using the update 
manager. Here it goes:

1) Imagine no Eclipse is installed in your machine.
2) Unzip build 20020529 into c:\eclipse\20020529
3) Start eclipse with -data c:\temp and do some basic work
4) Close Eclipse.
5) Unzip build 20020530 into c:\eclipse\20020530
6) move folder c:\eclipse\20020529 to c:\eclipse\old\20020529
7) Start eclipse (0530) with -data c:\temp and do some basic work
8) Note that an empty folder was created: c:\eclipse\20020529
Comment 3 Vlad Klicnik CLA 2002-06-04 13:13:21 EDT
F3 candidate

Also see bug 18520 (likely related)
Comment 4 Vlad Klicnik CLA 2002-06-09 19:51:38 EDT
The fix for this problem is simple, but has side-effects on reconciliation 
processing that are too "scary" this close to F3. Consequently am removing the 
defect from the F3 target list, and increasing severity for post-2.0.

The problem is in SiteFileFactory.createSite(URL). The retry logic when a 
"file:" URL points to a non-existent location actually causes the directory path 
to be created. Removing the code that created the file path changed state 
reconciliation behavior, so will delay making this change until after 2.0.
Comment 5 Christophe Elek CLA 2002-07-15 13:53:16 EDT
Code now throws error if directory not found. Part of retry mecanism.
Removing Directory creation was returning a Site, throwing an error does not.
Test
Comment 6 Christophe Elek CLA 2002-08-22 09:48:37 EDT
verified with 0821

Installed a feature in a different site
Removed the site

In the history, you see the URL of the deleted site, the feature shows as broken
and the label is the URL of the feature