Bug 10917 - Patch support does not use mnemonics
Summary: Patch support does not use mnemonics
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 F2   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2002-03-06 21:39 EST by Nick Edgar CLA
Modified: 2002-06-03 08:01 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2002-03-06 21:39:45 EST 
Build 20020305

The Compare with / Patch wizard is missing mnemonics for controls on both 
pages.

On the Verify Patch page, it would help to give the checkbox tree a label with 
a mnemonic since the user often has to go back to it.
It would also help to have Select All and Deselect All buttons.
Comment 1 Till Bay CLA 2002-04-10 09:45:32 EDT 
Already in the context menu leading to that wizard a mnemonic is missing why 
not use the same one that's used for :T&eam:Create &Patch...
Comment 2 Andre Weinand CLA 2002-05-29 06:32:34 EDT 
Fixed for 20020529.
I didn't add Check All and Uncheck All options on the verify page because 
changing the check boxes is rarely necessary. If all goes well all hunks in a 
patch can be applied and they are automatically checked on. I they cannot be 
applied (and the checkboxes are off) the user is not able to force it to on.
So the only case where you want to change the checkbox state is when the file 
or hunk matches but you deliberately don't want to take it.
Comment 3 Erich Gamma CLA 2002-06-02 17:48:47 EDT 
pls verify
Comment 4 Adam Kiezun CLA 2002-06-03 08:01:51 EDT 
verified