Bug 105230 - [BIDI] need to add $nl$/ to icon paths for reversed icons
Summary: [BIDI] need to add $nl$/ to icon paths for reversed icons
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 105008
  Show dependency tree
 
Reported: 2005-07-26 17:23 EDT by Karice McIntyre CLA
Modified: 2005-08-05 10:35 EDT (History)
0 users

See Also:


Attachments
Patch to add $nl$ support (8.85 KB, patch)
2005-07-29 06:26 EDT, Dirk Baeumer CLA
no flags Details | Diff
Patch which increases version numbers as well. (10.31 KB, patch)
2005-07-29 06:33 EDT, Dirk Baeumer CLA
no flags Details | Diff
first patch (w/o plugin.xml) (3.94 KB, patch)
2005-08-01 15:37 EDT, Andre Weinand CLA
no flags Details | Diff
second patch (for plugin.xml) (723 bytes, patch)
2005-08-03 08:37 EDT, Andre Weinand CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karice McIntyre CLA 2005-07-26 17:23:02 EDT
Target for 3.1.1 release (NL release).

In Eclipse 3.1, icons are being supplied for BiDi locales that will appear as 
if the icon has been reversed.  For all plugins that supply icons, some code 
changes are required to support this that do not appear to be present when 
running Eclipse in a BiDi locale (get BiDi fragments then run Eclipse with 
program argument -nl ar_EG).  The following 2 items need to be checked:
1. Paths to icons/images that can appear flipped must be prefixed with $nl$/ 
(e.g. $nl$/ICON_PATH) - this includes paths to icons and images in plugin.xml.
2. Must use Platform.find(Bundle, Path) to create the URL that is used to 
create the image descriptor.
See Tod's Eclipse blog entry for more details on the code changes required. 
http://todcreaseyeclipse.blogspot.com/

NOTE: Only icons that have the possibility of being flipped need to have this 
prefix added - you can leave the paths of other icons as they are for 3.1.1 if 
you want to keep changes to a minimum.  You can get the BiDi nl fragments from 
Cam-Thu Le so that you can see which of your icons have a reversed counterpart 
in BiDi locales.  

The following plugins of this component have been identified as requiring this 
check:
*org.eclipse.compare 

Questions about this issue can be directed to Karice McIntyre or Tod Creasey.
Comment 1 Dirk Baeumer CLA 2005-07-29 06:26:29 EDT
Created attachment 25459 [details]
Patch to add $nl$ support
Comment 2 Dirk Baeumer CLA 2005-07-29 06:27:26 EDT
Andre the changes to the plugin.xml file should only be released after the code
changes (e..g for milestone build 10.August.
Comment 3 Dirk Baeumer CLA 2005-07-29 06:33:34 EDT
Created attachment 25460 [details]
Patch which increases version numbers as well.
Comment 4 Andre Weinand CLA 2005-08-01 15:37:23 EDT
Created attachment 25523 [details]
first patch (w/o plugin.xml)
Comment 5 Andre Weinand CLA 2005-08-03 08:37:28 EDT
Created attachment 25610 [details]
second patch (for plugin.xml)
Comment 6 Andre Weinand CLA 2005-08-03 08:42:41 EDT
both patches applied for M20050803
Comment 7 Andre Weinand CLA 2005-08-05 10:35:46 EDT
applied patches to HEAD for upcoming 3.2 M1