Bug 99801

Summary: Help Server page is poorly laid out
Product: [Eclipse Project] Platform Reporter: Michael Van Meekeren <michaelvanmeekeren>
Component: User AssistanceAssignee: Dejan Glozic <dejan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: konradk
Version: 3.1Keywords: polish
Target Milestone: 3.1 RC3   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
The proposed changes
none
Improved layout and fixed typo. none

Description Michael Van Meekeren CLA 2005-06-13 15:34:32 EDT 
This page should be updated.

The labels before text are being used to describe in full what the text widget
below is used for.  This makes it difficult to quickly read and enter what you
need.  

The text widget for Host and Port are as wide as the while page but typically do
not need that much space.
Comment 1 Dejan Glozic CLA 2005-06-13 15:45:09 EDT 
+1 The extra text is not needed because F1 opens a new dynamic help pane with 
the exact same information.

If embedding help in the page is needed, I suggest having this text moved into 
the existing 'Note' text, e.g.:

Host name or IP address: [                            ]
Server port:             [                            ]

Note: Leave the fields above empty to have the IP address and/or port number 
dynamically assigned by the help system. If the server is already running, 
these preferences will only apply after restarting.
Comment 2 Konrad Kolosowski CLA 2005-06-13 15:52:40 EDT 
+0.  Not critical.  The page look the same as in 2.1 and 3.0, and values do 
not need to be changed unless there is problems with the server startup.
Comment 3 Dejan Glozic CLA 2005-06-13 16:13:17 EDT 
Granted, but the fix is trivial and the fact that it was like this for a long 
time should not stop us from polish.
Comment 4 Konrad Kolosowski CLA 2005-06-13 22:37:12 EDT 
Do you propose changing layout such that text fields do not take full width or 
just the text of the labels?  The change should be tested on most platforms by 
if released for RC3.

The proposed note text looses information.  Help does not assign IP addresses 
of the machine, it just picks one.
"the above fields" sounds better then "the fields above"
"and/or" should be "and" if both fields are empty.
Comment 5 Dejan Glozic CLA 2005-06-14 14:26:01 EDT 
I propose that the layout be exactly as below (i.e. in the same row).
With your changes:

Host name or IP address: [                            ]
Server port:             [                            ]

Note: Leave the above fields empty to have the IP address and port number 
dynamically computed by the help system. If the server is already running, 
these preferences will only apply after restarting.
Comment 6 Konrad Kolosowski CLA 2005-06-14 15:21:56 EDT 
OK.  Let's see the patch.
Comment 7 Dejan Glozic CLA 2005-06-14 16:09:48 EDT 
Attached is the proposed change. I also took the opportunity to make the 
layout more flexible regarding long wrapped text.
Comment 8 Dejan Glozic CLA 2005-06-14 16:10:20 EDT 
Created attachment 23100 [details]
The proposed changes
Comment 9 Konrad Kolosowski CLA 2005-06-14 16:50:01 EDT 
"effectafter" should be two words.

There is also an issue with the layout.  I doubled the text in the note to 
simulate translations (that have longer text then English).  The hight of the 
preference dialog is already increased, while the page is actually only half 
used.
Comment 10 Dejan Glozic CLA 2005-06-14 16:57:08 EDT 
Created attachment 23110 [details]
Improved layout and fixed typo.
Comment 11 Konrad Kolosowski CLA 2005-06-14 17:16:50 EDT 
Big improvement.  +1 for RC3.
Comment 12 Dejan Glozic CLA 2005-06-14 17:25:03 EDT 
There you go :-)
Fixed.