Bug 99013

Summary: Product Configuration -> Feature -> Scan for updates: it scanns ALL features
Product: [Eclipse Project] Platform Reporter: Michael Scharf <eclipse>
Component: Update (deprecated - use Eclipse>Equinox>p2)Assignee: Dejan Glozic <dejan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: birsan, jeem, jeffmcaffer
Version: 3.1   
Target Milestone: 3.1 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch to search specified feature none

Description Michael Scharf CLA 2005-06-08 13:41:03 EDT 
In the UI it says below the link: "Search for updates for this feature".

However in 3.1RC1 it scanns always ALL features. This is annoying,
because scanning all features can take long....

I also think the comment is misleading....
Comment 1 Dejan Glozic CLA 2005-06-08 13:47:09 EDT 
Looks like a regression - Branko, please investigate.
Comment 2 Dejan Glozic CLA 2005-06-09 11:36:31 EDT 
Dorian, the scenario seems busted. The install wizard1 is not supposed to come 
up in this case. The user selected to find updates for a closed set of 
features, so there is nothing to choose in this wizard. We should immediately 
launch the search job and go straight into install wizard 2 when done.

We should try to get this done today in time for RC2 build, since this is a 
regression of the function that worked in 3.0.
Comment 3 Dorian Birsan CLA 2005-06-09 12:08:20 EDT 
the code change involves a slight modification to an API class UpdateJob.

This is a concrete class, added very recently (M6 I think), primarily driven by
Jeff.

The modification would be to allow passing in an already built SearchRequest
object when looking for updates. Currently a search request can only be passed
when searching for new features. In the update case, a new search request
(searching for updates to ALL features) is constructed. This case needs to be
able to constrain which features to search for updates.


jim, could you please approve this API change? Thanks.
Comment 4 Dorian Birsan CLA 2005-06-09 14:59:28 EDT 
Created attachment 22734 [details]
patch to search specified feature
Comment 5 Jim des Rivieres CLA 2005-06-09 15:52:54 EDT 
API addition of UpdateJob.UpdateJob(String,boolean,boolean,IFeature[]) 
approved for 3.1RC2.
Comment 6 Dejan Glozic CLA 2005-06-09 20:21:40 EDT 
Released and tweaked to show the search progress in the configuration window's 
status line.