Bugzilla – Full Text Bug Listing
| Summary: | [5.0] @SuppressWarnings({"nls"}) does not work for unexternalized strings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Tobias Widmer <tobias_widmer> | ||||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | artur.brinkmann | ||||||
| Version: | 3.1 | ||||||||
| Target Milestone: | 3.1 RC2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
nls is not supported yet. I found a bug for the nls support. It should indeed work. *** Bug 95951 has been marked as a duplicate of this bug. *** Using this test case:
@SuppressWarnings({"javadoc"}) //$NON-NLS-1$
public class X<T> {
String test= ""; //$NON-NLS-1$
}
I get no warning for the javadoc warning (missing javadoc for public type).
If I comment out the @SuppressWarnings line, then I get it.
So from my point of view, the support for "javadoc" is fine.
I will attach the patch to fix the nls bug.
Created attachment 21890 [details]
Apply on HEAD
Created attachment 21893 [details]
Apply on HEAD of org.eclipse.jdt.core.tests.compiler
Corresponding regression test
Tobias, Could you please confirm that "javadoc" actually works? Yes, the "javadoc" works. The test case was rather designed to show that the "nls" annotation does not work on strings used in the annotation itself. Then I update the title accordingly Change in org.eclipse.jdt.internal.compiler.impl.CompilerOptions. Fixed and released in HEAD. Regression test added in org.eclipse.jdt.core.tests.compiler.regression.AnnotationTest.test147 Verified for 3.1RC2 using build N20050607-0010 + JDT/COre HEAD Verified for 3.1 RC2 using build I20050610-0010 |
I20050527-0010: Use snippet: @SuppressWarnings({"javadoc","nls"}) class Test<T> { String test= ""; } with javadoc processing and nls checking enabled